Date: Tue, 26 Oct 1999 08:39:20 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: alpha@freebsd.org Subject: Re: small fix for irq mappig probelm Message-ID: <Pine.BSF.4.10.9910260838170.331-100000@salmon.nlsystems.com> In-Reply-To: <14354.8792.767477.900314@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 23 Oct 1999, Andrew Gallatin wrote: > > Doug, > > When using a kernel built after your recent changes to pci.c, alpha > PCI devices with intline==0 fail to map their interrupt. This > typically happens with the on-board tulip in a miata: > > de0: <Digital 21143 Fast Ethernet> irq 0 at device 3.0 on pci0 > pci_map_int: can't allocate interrupt > > > The appended patch fixes it, but I am unsure it is correct. Can you > approve it? > > Thanks, I think the correct fix is to compare against 255. I will commit the following patch: Index: pci.c =================================================================== RCS file: /home/ncvs/src/sys/pci/pci.c,v retrieving revision 1.123 diff -u -r1.123 pci.c --- pci.c 1999/10/17 06:48:47 1.123 +++ pci.c 1999/10/26 07:36:14 @@ -1045,7 +1045,7 @@ (unsigned int) base, ln2size); } } - if (cfg->intline) + if (cfg->intline != 255) resource_list_add(rl, SYS_RES_IRQ, 0, cfg->intline, cfg->intline, 1); } -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9910260838170.331-100000>