Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Feb 2003 03:24:14 -0500 (EST)
From:      Alan Eldridge <alane@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/48451: irc/xchat2: PLIST_SUBS overwrites itself so port won't package
Message-ID:  <200302190824.h1J8OE9v033671@wwweasel.geeksrus.net>

next in thread | raw e-mail | index | archive | help

>Number:         48451
>Category:       ports
>Synopsis:       irc/xchat2: PLIST_SUBS overwrites itself so port won't package
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 19 00:30:03 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Alan Eldridge
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.7-STABLE FreeBSD 4.7-STABLE #0: Sat Feb 15 04:01:53 EST 2003 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/VROOM i386


>Description:

PLIST_SUB= used where it should be += so substitutions are overwitten
by later ones.

>How-To-Repeat:
>Fix:


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/irc/xchat2/Makefile,v
retrieving revision 1.108
diff -d -U4 -r1.108 Makefile
--- Makefile	18 Feb 2003 20:30:17 -0000	1.108
+++ Makefile	19 Feb 2003 08:17:56 -0000
@@ -42,12 +42,12 @@
 
 .if defined(WITH_PYTHON)
 USE_PYTHON=    yes
 CONFIGURE_ARGS+=	--enable-python
-PLIST_SUB=	PYTHON=""
+PLIST_SUB+=	PYTHON=""
 .else
 CONFIGURE_ARGS+=	--disable-python
-PLIST_SUB=	PYTHON="@comment "
+PLIST_SUB+=	PYTHON="@comment "
 .endif
 
 .if defined(WITH_TCL)
 LIB_DEPENDS=    tcl83.1:${PORTSDIR}/lang/tcl83
@@ -55,12 +55,12 @@
 CONFIGURE_ENV=  CPPFLAGS="-I${LOCALBASE}/include ${PTHREAD_CFLAGS} \
 		-I${LOCALBASE}/include/tcl8.3" \
 		LIBS="-L${LOCALBASE}/lib ${PTHREAD_LIBS} \
 		-L${LOCALBASE}/lib/tcl8.3"
-PLIST_SUB=	TCL=""
+PLIST_SUB+=	TCL=""
 .else
 CONFIGURE_ARGS+=	--enable-tcl=no
-PLIST_SUB=	TCL="@comment "
+PLIST_SUB+=	TCL="@comment "
 .endif
 
 pre-everything::
 .if !defined(WITH_PYTHON) || !defined(WITH_SOCKS) || !defined(WITH_TCL)

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302190824.h1J8OE9v033671>