Date: Tue, 23 Mar 2004 13:38:31 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: freebsd-net@freebsd.org Subject: in_pcbbind_setup(), etc. Message-ID: <20040323123831.GM8930@darkness.comp.waw.pl>
next in thread | raw e-mail | index | archive | help
--Rm5rkB9L8kG9H2n8 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hmm. I'm looking at in_pcbbind_setup() and this doesn't looks right in few places. For example: 'td' can be NULL? It is offten tested, but not always, Line 290: if (sin->sin_addr.s_addr !=3D INADDR_ANY) if (prison_ip(td->td_ucred, 0, &sin->sin_addr.s_addr)) return(EINVAL); td_ucred is used, but 'td' is not tested. If this is always current thread, it can't be NULL, right? If this not have to be current thread, we cannot touch td_ucred here, because (from proc.h): [...] * k - only accessed by curthread [...] struct ucred *td_ucred; /* (k) Reference to credentials. */ [...] Not telling that we can just remove this argument if this is always current thread. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --Rm5rkB9L8kG9H2n8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAYC/HForvXbEpPzQRAgp+AJ4r6LeDODuRxJxYRBQkC1j6N3xQ/wCfZAYl MCqAl8qF5KoTxmM//Vjn3cM= =HL/f -----END PGP SIGNATURE----- --Rm5rkB9L8kG9H2n8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040323123831.GM8930>