Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Jan 2014 13:06:03 +0100
From:      Zbigniew Bodek <zbb@freebsd.org>
To:        Ian Lepore <ian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r260161 - in head/sys/arm: arm include
Message-ID:  <CALF_TxmutPj7T3nSMu2wgPeqmMVtwh2fM1P4%2BdquoMKQCRK=wQ@mail.gmail.com>
In-Reply-To: <1388976912.1158.331.camel@revolution.hippie.lan>
References:  <201401012003.s01K3ngn009757@svn.freebsd.org> <1388976912.1158.331.camel@revolution.hippie.lan>

next in thread | previous in thread | raw e-mail | index | archive | help
2014/1/6 Ian Lepore <ian@freebsd.org>:
> On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote:
>> Author: zbb
>> Date: Wed Jan  1 20:03:48 2014
>> New Revision: 260161
>> URL: http://svnweb.freebsd.org/changeset/base/260161
>>
>> Log:
>>   Add polarity and level support to ARM GIC
>>
>>   Add suport for setting triggering level and polarity in GIC.
>>   New function pointer was added to nexus which corresponds
>>   to the function which sets level/sense in the hardware (GIC).
>>
>>   Submitted by:       Wojciech Macek <wma@semihalf.com>
>>   Obtained from:      Semihalf
>>
>> Modified:
>>   head/sys/arm/arm/gic.c
>>   head/sys/arm/arm/intr.c
>>   head/sys/arm/arm/nexus.c
>>   head/sys/arm/include/intr.h
>>
> [...]
>> Modified: head/sys/arm/include/intr.h
>> ==============================================================================
>> --- head/sys/arm/include/intr.h       Wed Jan  1 19:38:15 2014        (r260160)
>> +++ head/sys/arm/include/intr.h       Wed Jan  1 20:03:48 2014        (r260161)
>> @@ -68,6 +68,7 @@
>>  #endif
>>
>>  #include <machine/psl.h>
>> +#include <sys/bus.h>
>>
>>  int arm_get_next_irq(int);
>>  void arm_mask_irq(uintptr_t);
>> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *,
>>      void *, int, int, void **);
>>  int arm_remove_irqhandler(int, void *);
>>  extern void (*arm_post_filter)(void *);
>> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig,
>> +    enum intr_polarity pol);
>>
>>  void gic_init_secondary(void);
>>
>
> It turns out that the new #include in this change is causing the current
> arm tinderbox failures.  Enums can't have forward decls anymore, so the
> fix for this may not be easy.
>
> -- Ian
>
>
I apologize.
I must have missed that somehow. I was assured that patches are fine.

Best regards
zbb



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALF_TxmutPj7T3nSMu2wgPeqmMVtwh2fM1P4%2BdquoMKQCRK=wQ>