Date: Mon, 23 Apr 2007 14:46:53 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-amd64@freebsd.org Cc: freebsd-i386@freebsd.org, Ariff Abdullah <ariff@freebsd.org> Subject: Re: AMD64 K8 Family C1E dead apic timer fixup Message-ID: <200704231446.54021.jhb@freebsd.org> In-Reply-To: <20070420195444.20bc4d3a.ariff@FreeBSD.org> References: <20070420195444.20bc4d3a.ariff@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 20 April 2007 07:54:44 am Ariff Abdullah wrote: > Will anybody object if I (or somebody else) commit this patch? > > http://people.freebsd.org/~ariff/test/k8_c1e.diff > > This should "fix" dead apic timer issues on latest AMD64 (Turion64 > X2 mostly, or later revision) where C1 Enhanced (C1E) mode enabled. > > Without this, the only way to make the timer work is to disable APIC > or even worst, to avoid executing HLT instruction > (machdep.cpu_idle_hlt=0), smp or non-smp. It affect both i386 and > amd64. > > See PR: i386/104678 for details. Does this fix all of the Turion lapic timer hangs? Some small tweaks to the comment would be: - s/present/presence/ - s/render/renders/ - s/apic timer/local APIC timer/ - s/dead, and/dead, so/ - s/reading Interrupt/reading the Interrupt/ - s/unset/clearing/ Also, is it ok to always mask off the upper 31 bits of the MSR instead of preserving their current state? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704231446.54021.jhb>