Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 01 Jul 2014 22:59:02 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 191531] [new port] devel/nginx-resty-redis (or should it be under databases?)
Message-ID:  <bug-191531-13-l9Hqn1y7Uw@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-191531-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-191531-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191531

--- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> ---
On first glance at your patch:

- Replace the custom DISTNAME, MASTER_SITES, GITVERSION and WRKSRC with the
USE_GITHUB and the GH_* variables. 

For more detail, see /usr/ports/Mk/bsd.sites.mk

- Strip "This Lua library is a" from COMMENT

See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-comment

- Bug summary says nginx-resty-redis, but the Makefile says lua-resty-redis,
please clarify and update patch if necessary.

Finally, if you haven't already, run your port through portlint(8) port test
(in ports-mgmt/porttools) and redports.org, fix any QA issues identified and
report back here with URL's or output if they pass.

Thanks for your new port submission!

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191531-13-l9Hqn1y7Uw>