Date: Tue, 19 Oct 2010 15:33:20 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: d@delphij.net Cc: "Andrey V. Elsukov" <bu7cher@yandex.ru>, FreeBSD Current <freebsd-current@FreeBSD.ORG> Subject: Re: [zfs] Mounting from (...) failed with error 19 Message-ID: <023E61D3-7E4C-4793-95A0-088ABCD0F92F@mac.com> In-Reply-To: <4CBE0BE5.2060708@delphij.net> References: <4CBCDD3A.9070404@delphij.net> <4CBD26B4.2020205@yandex.ru> <4CBDB17C.4040607@yandex.ru> <44B33168-C432-4AA0-A765-8222DB4C048D@mac.com> <4CBE0BE5.2060708@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 19, 2010, at 2:21 PM, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 10/19/10 08:49, Marcel Moolenaar wrote: >> >> On Oct 19, 2010, at 7:55 AM, Andrey V. Elsukov wrote: >> >>> On 19.10.2010 09:03, Andrey V. Elsukov wrote: >>>>> Mounting from (...) failed with error 19 >>>>> >>>>> On boot. The system is using pure ZFS setup. It seems that 19 means >>>>> ENODEV but according to the dmesg the device do exist. >>>> >>>> Yes, i have the same problem. >>> >>> I fixed it with attached patch. >> >> Makes sense. "tank" (or its namesake) isn't a real device. >> Feel free to commit to unbreak things, but we may want to >> rethink this from a generality point of view. Listing >> exceptions doesn't scale and we now have 2 (the first was >> the empty device name as used by nfs, and now also zfs). >> >> Good catch, BTW. > > Yes good catch, it fixed the problem for me as well. > > What about the attached patch? I'm going to give it a swirl soon. The > difference is that it tests whether dev begins with /dev/. Interesting. I've been thinking about this too, but isn't exactly fool-proof. When devfs is the root file system, you can use "ufs:da0s1a" to refer to the device special file. It seems inconsistent to have "ufs:da0s1" fail when ufs:/dev/da0s1" works (a real scenario with USB based mass storage devices -- root mount is unheld as soon as umass is created, but before daX exists for it). This patch at least covers the problem cases with a single strstr(), and we may get away with the inconsistency given above by documenting it properly. Andrey: any thoughts? -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?023E61D3-7E4C-4793-95A0-088ABCD0F92F>