Date: 08 Mar 2003 12:48:13 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Glenn Johnson <glennpj@charter.net> Cc: FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: lost spinner in galeon2 Message-ID: <1047145693.96334.0.camel@shumai.marcuscom.com> In-Reply-To: <20030306050103.GA53509@gforce.johnson.home> References: <20030306050103.GA53509@gforce.johnson.home>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-qngenykxBhlsqtcDGlaO Content-Type: multipart/mixed; boundary="=-0nh8UlzNT3VJRsmHwwLs" --=-0nh8UlzNT3VJRsmHwwLs Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2003-03-06 at 00:01, Glenn Johnson wrote: > This is a strange one. I was using galeon2 (Gnome galeon 1.3.2) and > it crashed for some unknown reason. When I brought it back up, the > spinner is gone. If I go into "Edit -> Preferences -> User Interface" I > can see the list of spinners. Selecting the different spinners causes > the location bar to change size slightly to accommodate that particular > spinner size. So, at least the place holder is there for the spinner > but it is not showing up. I also checked this logged in as another user > to see if my configuration files had gone bad but get the same result, > no spinner. It was jut fixed in Galeon CVS. Here is a patch. This will be committed after the freeze lifts. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-0nh8UlzNT3VJRsmHwwLs Content-Disposition: attachment; filename=patch-src_galeon-spinner.c Content-Transfer-Encoding: quoted-printable Content-Type: text/x-c; name=patch-src_galeon-spinner.c; charset=ISO-8859-1 --- src/galeon-spinner.c.orig Sat Mar 8 12:42:06 2003 +++ src/galeon-spinner.c Sat Mar 8 12:45:06 2003 @@ -372,9 +372,7 @@ g_return_val_if_fail (IS_GALEON_SPINNER (widget), FALSE); =20 spinner =3D GALEON_SPINNER (widget); - if (!spinner->details->ready) { - return FALSE; - } + if (!GTK_WIDGET_DRAWABLE (widget)) return FALSE; =20 pixbuf =3D select_spinner_image (spinner); if (pixbuf =3D=3D NULL) { @@ -397,8 +395,8 @@ height =3D gdk_pixbuf_get_height (pixbuf); =20 /* Compute the offsets for the image centered on our allocation */ - x_offset =3D widget->allocation.x + (widget->allocation.width - width) / = 2; - y_offset =3D widget->allocation.y + (widget->allocation.height - height) = / 2; + x_offset =3D (widget->allocation.width - width) / 2; + y_offset =3D (widget->allocation.height - height) / 2; =20 pix_area.x =3D x_offset; pix_area.y =3D y_offset; @@ -424,18 +422,6 @@ return FALSE; } =20 -static void -galeon_spinner_map (GtkWidget *widget) -{ - GaleonSpinner *spinner; -=09 - spinner =3D GALEON_SPINNER (widget); - - GTK_WIDGET_CLASS (parent_class)->map (widget); - - spinner->details->ready =3D TRUE; -} - /* here's the actual timeout task to bump the frame and schedule a redraw = */ =20 static gboolean=20 @@ -444,9 +430,7 @@ GaleonSpinner *spinner; =20 spinner =3D GALEON_SPINNER (callback_data); - if (!spinner->details->ready) { - return TRUE; - } + if (!GTK_WIDGET_DRAWABLE (spinner)) return FALSE; =20 spinner->details->current_frame +=3D 1; if (spinner->details->current_frame > spinner->details->max_frame - 1) { @@ -759,7 +743,6 @@ widget_class->enter_notify_event =3D galeon_spinner_enter_notify_event; widget_class->leave_notify_event =3D galeon_spinner_leave_notify_event; widget_class->size_request =3D galeon_spinner_size_request;=09 - widget_class->map =3D galeon_spinner_map; } =20 static void --=-0nh8UlzNT3VJRsmHwwLs-- --=-qngenykxBhlsqtcDGlaO Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+aizdb2iPiv4Uz4cRAqJfAJ9+0JPbaJKCGHEdpiYSMGSJo5s7WQCgj7EL dlIgG8LqGYE66XrUsMmHrTo= =Rujy -----END PGP SIGNATURE----- --=-qngenykxBhlsqtcDGlaO-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1047145693.96334.0.camel>