Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 May 2012 09:23:14 +0000
From:      Chris Rees <crees@FreeBSD.org>
To:        Guido Falsi <madpilot@freebsd.org>
Cc:        Peter Jeremy <peterjeremy@acm.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, Thomas Abthorpe <tabthorpe@freebsd.org>, cvs-ports@freebsd.org, nemysis <nemysis@gmx.ch>
Subject:   Re: cvs commit: ports/graphics Makefile ports/graphics/viewnior Makefile distinfo pkg-descr pkg-plist ports/graphics/viewnior/files patch-po_Makefile.in.in
Message-ID:  <CADLo83-Pkij0SkxrFgYd9%2BdZ0DcYNM133AcoYs34vAO6ueXkNg@mail.gmail.com>
In-Reply-To: <20120502084805.GA83818@megatron.madpilot.net>
References:  <201204301752.q3UHquWJ034347@repoman.freebsd.org> <20120501204522.GA23385@server.vk2pj.dyndns.org> <20120501234357.792c2599@nemysis3now.no-ip.biz> <20120502084805.GA83818@megatron.madpilot.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2 May 2012 09:48, "Guido Falsi" <madpilot@freebsd.org> wrote:
>
> On Tue, May 01, 2012 at 11:43:57PM +0200, nemysis wrote:
> > On Wed, 2 May 2012 06:45:22 +1000
> > Peter Jeremy <peterjeremy@acm.org> wrote:
> >
> > > On 2012-Apr-30 17:52:56 +0000, Guido Falsi <madpilot@FreeBSD.org>
wrote:
> > > >  This is Viewnior, an image viewer program. Created to be simple,
fast
> > > >  and elegant. It's minimalistic interface provides more screenspace
for
> > > >  your images. Among its features are:
> > >
> > > This looks interesting, thanks.
> > >
> > > I notice that NLS is a configure-time option but USE_GETTEXT is
> > > unconditionally set (as well as being set within the !WITHOUT_NLS
> > > condtiional block).  I presume this is a cut-and-paste error.
> > >
> >
> >
> > I have seen that in FreeBSD Ports collection is older version as you
have
> > give me and i have adjusted.
> >
> > diff -ruN viewnior.old viewnior > viewnior.diff
> >
> > Should I this send to freebsd-ports-bugs@freebsd.org
>
> I see that the problem is caused by USE_GETTEXT being defined both
> unconditionally and in the option check. Sorry, this is my fault.
>
> If you approve I'd commit the attached simple fix.
>

Please go for it- sorry I missed it too.

Chris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-Pkij0SkxrFgYd9%2BdZ0DcYNM133AcoYs34vAO6ueXkNg>