Date: Wed, 18 Feb 1998 09:49:26 +1100 From: Bruce Evans <bde@zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen getpass.c Message-ID: <199802172249.JAA29472@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified files: (Branch: RELENG_2_2) > lib/libc/gen getpass.c > Log: > MFC: more fascist signal blocking. > > Revision Changes Path > 1.5.2.1 +11 -40 src/lib/libc/gen/getpass.c Actually, it is to spell the signal handling POSIXly, and as an unlogged side effect, to (uncleanly) back out revisions 1.2 and 1.3. Revisions 1.2 and 1.3 break the signal handling for callers that ignore signals, e.g., login(1) and passwd(1). Login was kludged to not ignore signals for the getpass() call and in surrounding code so that the broken getpass() didn't affect it. It's not clear what happens if a previously-ignored signal occurs while the surrounding code is running. A correct version of revisions 1.2 and 1.3 would only catch signals if signals are being defaulted. It's not clear what it should do if signals are being caught. Keeping the historical behaviour would be safest. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802172249.JAA29472>