Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jul 2001 09:42:43 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Dima Dorfman <dd@FreeBSD.org>, "David O'Brien" <obrien@FreeBSD.org>
Subject:   Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us
Message-ID:  <XFMail.010717094243.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.21.0107171745520.65013-100000@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 17-Jul-01 Bruce Evans wrote:
> On Mon, 16 Jul 2001, John Baldwin wrote:
> 
>> On 16-Jul-01 David O'Brien wrote:
>> > On Mon, Jul 16, 2001 at 09:01:16AM -0700, John Baldwin wrote:
>> >> > zic is vendor code; please back this out.
>> >> 
>> >> Why isn't it in src/contrib then?
>> > 
>> > Many things that today would be in src/contrib were imported into
>> > {,gnu}/usr.?bin.  GNU grep is another example of this.  the `contrib'
>> > convention we use today doesn't date back to 2.0.
>> 
>> It's (realtively) small, so why not move it to contrib/ to make this more
>> obvious?  src/gnu is already somewhat off in its own namespace and is
>> already
>> treated as contrib stuff, however, how are committers supposed to know what
>> "magical" parts of src/usr.s?bin/ are actually 3rd party?
> 
> By reading the cvs history.

So I need to read the cvs histoy on every file I commit to just to check for
hidden exceptions to otherwise practiced guidelines?  It doesn't even have a
MAINTAINER to hint that there might be something special about this program.
Why set guidelines for handling things and then not follow them and hit people
over the head for not digging down and finding the one tiny place that the
exception is documented?

> Bruce

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010717094243.jhb>