Date: Tue, 28 Nov 2000 22:19:44 -0400 From: "Jeroen C. van Gelderen" <jeroen@vangelderen.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: Warner Losh <imp@village.org>, "Brian F. Feldman" <green@FreeBSD.ORG>, obrien@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c Message-ID: <3A2467C0.497F69FB@vangelderen.org> References: <20001126182240.A8051@fw.wintelcom.net> <bright@wintelcom.net> <200011262140.eAQLe2576200@green.dyndns.org> <20001126182240.A8051@fw.wintelcom.net> <200011280524.WAA07413@harmony.village.org> <20001127221535.Y8051@fw.wintelcom.net> <3A245F2C.9842890E@vangelderen.org> <20001128181437.S8051@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote: > > * Jeroen C. van Gelderen <jeroen@vangelderen.org> [001128 17:43] wrote: > > Alfred Perlstein wrote: > > > > > > * Warner Losh <imp@village.org> [001127 21:24] wrote: > > > > > > > > Shouldn't this be > > > > if (to.tv_usec >= 1000000) { > > > > to.tv_sec += to.tv_usec / 1000000; > > > > to.tv_usec %= 1000000; > > > > } > > > > > > Yes, but it's overkill as afaik = 2000000 > > > shouldn't happen. > > > > > > So, shouldn't it be: > > > > ASSERT(to.tv_usec < 2000000); > > to.tv_usec += tv.tv_usec; > > if (to.tv_usec >= 1000000) { > > to.tv_usec -= 1000000; > > to.tv_sec++; > > } > > > > No it should not, but it could. Depends on the shop you are working in I guess. Why should it not in this case? Cheers, Jeroen -- Jeroen C. van Gelderen - jeroen@vangelderen.org "It is not utopian to work for a society without taxation; it is utopian to think that the power to tax won't be abused once it is granted." -- Murray N. Rothbard (1926-1995) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A2467C0.497F69FB>