Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Jul 1999 02:09:23 -0700
From:      Mike Smith <mike@smith.net.au>
To:        Brian Somers <brian@Awfulhak.org>
Cc:        John-Mark Gurney <jmg@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net if_tun.c 
Message-ID:  <199907240909.CAA00421@dingo.cdrom.com>
In-Reply-To: Your message of "Sat, 24 Jul 1999 03:51:00 BST." <199907240251.DAA03865@keep.lan.Awfulhak.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
> > jmg         1999/07/23 13:08:28 PDT
> > 
> >   Modified files:
> >     sys/net              if_tun.c 
> >   Log:
> >   fix a problem w/ zero byte writes to the tunnel device.  It would bypass
> >   the loop and not set an error, so we would then try to access an invalid
> >   mbuf...
> 
> I don't think I agree that writing 0 bytes should result in EIO, 
> perhaps EINVAL would be more apt ?

I'd actually say that it's not an error to write 0 bytes.  The routine 
should do nothing and return success, or write a packet with no 
contents (depending on the assumed semantics of the tun device).

-- 
\\  The mind's the standard       \\  Mike Smith
\\  of the man.                   \\  msmith@freebsd.org
\\    -- Joseph Merrick           \\  msmith@cdrom.com




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907240909.CAA00421>