Date: Wed, 12 Nov 2008 21:59:45 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Kip Macy <kmacy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r184864 - user/kmacy/HEAD_fast_multi_xmit/sys/netinet Message-ID: <alpine.BSF.1.10.0811122159190.89472@fledge.watson.org> In-Reply-To: <200811120732.mAC7W7Sr023153@svn.freebsd.org> References: <200811120732.mAC7W7Sr023153@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Nov 2008, Kip Macy wrote:
> - if (tp->t_maxopd <= mss)
> - return (inp);
> - tcp_output_send(tp);
> +
> + if ((tp->t_flags & TF_RECURSE) == 0) {
> + tp->t_flags |= TF_RECURSE;
> + tcp_output_send(tp);
> + tp->t_flags &= ~TF_RECURSE;
> + }
Perhaps TF_DONTRECURSE? I find the current polarity slightly confusing.
Robert N M Watson
Computer Laboratory
University of Cambridge
> +
> return (inp);
> }
>
>
> Modified: user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h
> ==============================================================================
> --- user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h Wed Nov 12 07:16:23 2008 (r184863)
> +++ user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h Wed Nov 12 07:32:07 2008 (r184864)
> @@ -127,7 +127,8 @@ struct tcpcb {
> #define TF_ECN_PERMIT 0x4000000 /* connection ECN-ready */
> #define TF_ECN_SND_CWR 0x8000000 /* ECN CWR in queue */
> #define TF_ECN_SND_ECE 0x10000000 /* ECN ECE in queue */
> -
> +#define TF_RECURSE 0x20000000 /* potentially recursing in tcp_output */
> +
> tcp_seq snd_una; /* send unacknowledged */
> tcp_seq snd_max; /* highest sequence number sent;
> * used to recognize retransmits
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.1.10.0811122159190.89472>