Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Mar 2004 15:17:08 +0100
From:      Matthias Andree <matthias.andree@gmx.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/63586: [MAINTAINER] sysutils/e2fsprogs: avoid double packaging of large file
Message-ID:  <E1AxoEG-000DjG-Gs@libertas.emma.line.org>
Resent-Message-ID: <200403011420.i21EK3jM073250@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         63586
>Category:       ports
>Synopsis:       [MAINTAINER] sysutils/e2fsprogs: avoid double packaging of large file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 01 06:20:03 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Matthias Andree
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD libertas.emma.line.org 4.9-STABLE FreeBSD 4.9-STABLE #85: Sun Feb 29 18:27:00 CET 2004
>Description:
This patch stops the post-install phase from breaking a hard link that led to a
double packaging of the static e2fsck executable under different names and
caused waste of space (read: bloat) in the binary package.

The shared e2fsck executable is no longer installed or packaged, saving another
100+ kByte (uncompressed).

User-visible change: e2fsck.static is gone, e2fsck is now the static version,
the pkg-message has tracked this change and been adjusted accordingly.

The patch cuts the FreeBSD-4 i386 binary package size from 2,200 to 1,316 kB
without any loss in functionality.

Savings on other architectures or versions have not been researched.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- e2fsprogs-1.35_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/sysutils/e2fsprogs/Makefile /root/e2fsprogs/Makefile
--- /usr/ports/sysutils/e2fsprogs/Makefile	Mon Mar  1 13:16:23 2004
+++ /root/e2fsprogs/Makefile	Mon Mar  1 14:07:03 2004
@@ -7,6 +7,7 @@
 
 PORTNAME=	e2fsprogs
 PORTVERSION=	1.35
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -88,8 +89,6 @@
 	${RM} ${PREFIX}/sbin/filefrag
 	${RM} ${PREFIX}/man/man8/filefrag.8
 	${INSTALL_PROGRAM} ${WRKSRC}/fsck_ext2fs ${PREFIX}/sbin/
-	${INSTALL_PROGRAM} ${WRKSRC}/e2fsck/e2fsck.shared ${PREFIX}/sbin/e2fsck
-	${INSTALL_PROGRAM} ${WRKSRC}/e2fsck/e2fsck.static ${PREFIX}/sbin/e2fsck.static
 	@${ECHO_MSG}
 	@${CAT} ${PKGMESSAGE}
 	@${ECHO_MSG}
diff -ruN --exclude=CVS /usr/ports/sysutils/e2fsprogs/files/pkg-message.in /root/e2fsprogs/files/pkg-message.in
--- /usr/ports/sysutils/e2fsprogs/files/pkg-message.in	Sat Feb 28 17:57:09 2004
+++ /root/e2fsprogs/files/pkg-message.in	Mon Mar  1 14:07:12 2004
@@ -8,7 +8,7 @@
 
 ln -f %%PREFIX%%/sbin/fsck_ext2fs /sbin/ 2>/dev/null \
   || install -m755 %%PREFIX%%/sbin/fsck_ext2fs /sbin/
-ln -f %%PREFIX%%/sbin/e2fsck.static /sbin/e2fsck 2>/dev/null \
-  || install -m755 %%PREFIX%%/sbin/e2fsck.static /sbin/e2fsck
+ln -f %%PREFIX%%/sbin/e2fsck /sbin/e2fsck 2>/dev/null \
+  || install -m755 %%PREFIX%%/sbin/e2fsck /sbin/e2fsck
 
 IMPORTANT: you also need to repeat the above steps after a port upgrade!
diff -ruN --exclude=CVS /usr/ports/sysutils/e2fsprogs/pkg-plist /root/e2fsprogs/pkg-plist
--- /usr/ports/sysutils/e2fsprogs/pkg-plist	Sat Feb 28 17:57:09 2004
+++ /root/e2fsprogs/pkg-plist	Mon Mar  1 14:58:30 2004
@@ -48,7 +48,6 @@
 sbin/debugfs
 sbin/dumpe2fs
 sbin/e2fsck
-sbin/e2fsck.static
 sbin/e2image
 sbin/e2label
 sbin/findfs
--- e2fsprogs-1.35_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1AxoEG-000DjG-Gs>