Date: Tue, 16 Apr 2013 15:20:03 +0200 From: keramida@ceid.upatras.gr (Giorgos Keramidas) To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Gregory Shapiro <gshapiro@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r246880 - in head: lib/libsm libexec/mail.local libexec/smrsh share/mk usr.bin/vacation usr.sbin/sendmail Message-ID: <87vc7m629o.fsf@saturn.laptop> In-Reply-To: <516D13C5.70900@FreeBSD.org> (Dimitry Andric's message of "Tue, 16 Apr 2013 11:03:01 %2B0200") References: <201302162017.r1GKHVdY022667@svn.freebsd.org> <87a9ozayzk.fsf@saturn.laptop> <516D13C5.70900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 16 Apr 2013 11:03:01 +0200, Dimitry Andric <dim@FreeBSD.org> wrote: > On 2013-04-16 06:19, =CE=93=CE=B9=CF=8E=CF=81=CE=B3=CE=BF=CF=82 =CE=9A=CE= =B5=CF=81=CE=B1=CE=BC=CE=AF=CE=B4=CE=B1=CF=82 wrote: >> On Sat, 16 Feb 2013 20:17:31 +0000 (UTC), Dimitry Andric <dim@FreeBSD.or= g> wrote: > ... >>> Since clang 3.2 now has an option to suppress warnings about implici= tly >>> promoted K&R parameters, remove the workarounds added for sendmail >>> components in r228558. > ... >> The part of the commit that removes NO_WERROR.clang for usr.sbin/sendmai= l/ >> breaks the build of Sendmail with -DSASL. I just tried rebuilding Sendm= ail >> with the following in "/etc/make.conf": >> >> # Build Sendmail with SASL support. >> SENDMAIL_CFLAGS ?=3D -I/usr/local/include -DSASL=3D20126 >> SENDMAIL_LDFLAGS ?=3D -L/usr/local/lib >> SENDMAIL_LDADD ?=3D -lsasl2 >> >> The warnings that usersmtp.c still triggers when -DSASL is used are: >> >> : cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src >> -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/include >> -I. -DNEWDB -DNIS -DTCPWRAPPERS -DMAP_REGEX -DDNSMAP -DNETINET6 >> -DSTARTTLS -D_FFR_TLS_1 -I/usr/local/include -DSASL=3D20126 -std=3Dgnu99 >> -Qunused-arguments -fstack-protector -Wsystem-headers >> -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int >> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality >> -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum >> -Wno-knr-promoted-parameter -Wno-parentheses -c >> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c >> : >> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1797:50: >> warning: incompatible pointer types passing 'void ()' to parameter of >> type 'void (*)(char *, bool, MAILER *, struct >> : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] >> : smtpresult =3D reply(m, mci, e, TimeOuts.to_auth, getsasldata,= NULL, >> : ^~~~~~~~~~~ > > Have you tried the patch I posted here? > > http://lists.freebsd.org/pipermail/freebsd-current/2013-March/040634.html > > If people feel this is the right approach, I am happy to commit it. If > people prefer to just shut up warnings, I am happy with that too. Confirmed. This fixes the build of usr.sbin/sendmail even without the NO_WERROR.clang=3D option. Thanks :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87vc7m629o.fsf>