Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Aug 2009 05:42:06 -0500
From:      Robert Noland <rnoland@FreeBSD.org>
To:        Nick Hibma <n_hibma@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   Re: svn commit: r196169 - stable/7/sys/pci
Message-ID:  <1250160126.1823.11.camel@balrog.2hip.net>
In-Reply-To: <200908130820.n7D8KCgt093511@svn.freebsd.org>
References:  <200908130820.n7D8KCgt093511@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2009-08-13 at 08:20 +0000, Nick Hibma wrote:
> Author: n_hibma
> Date: Thu Aug 13 08:20:12 2009
> New Revision: 196169
> URL: http://svn.freebsd.org/changeset/base/196169
> 
> Log:
>   Hide aperture size and stolen memory behind bootverbose.

Why?  This information can be useful and doesn't need to be buried in
the verbose boot log.

robert.

> Modified:
>   stable/7/sys/pci/agp_i810.c
> 
> Modified: stable/7/sys/pci/agp_i810.c
> ==============================================================================
> --- stable/7/sys/pci/agp_i810.c	Thu Aug 13 08:18:29 2009	(r196168)
> +++ stable/7/sys/pci/agp_i810.c	Thu Aug 13 08:20:12 2009	(r196169)
> @@ -474,12 +474,13 @@ agp_i810_attach(device_t dev)
>  				agp_generic_detach(dev);
>  				return EINVAL;
>  		}
> -		if (sc->stolen > 0) {
> -			device_printf(dev, "detected %dk stolen memory\n",
> -			    sc->stolen * 4);
> +
> +		if (bootverbose) {
> +			device_print_prettyname(dev);
> +			if (sc->stolen > 0)
> +				printf("detected %dk stolen memory, ", sc->stolen * 4);
> +			printf("aperture size is %dM\n", sc->initial_aperture / 1024 / 1024);
>  		}
> -		device_printf(dev, "aperture size is %dM\n",
> -		    sc->initial_aperture / 1024 / 1024);
>  
>  		/* GATT address is already in there, make sure it's enabled */
>  		pgtblctl = bus_read_4(sc->sc_res[0], AGP_I810_PGTBL_CTL);
> @@ -664,9 +665,13 @@ agp_i810_attach(device_t dev)
>  		gtt_size += 4;
>  
>  		sc->stolen = (stolen - gtt_size) * 1024 / 4096;
> -		if (sc->stolen > 0)
> -			device_printf(dev, "detected %dk stolen memory\n", sc->stolen * 4);
> -		device_printf(dev, "aperture size is %dM\n", sc->initial_aperture / 1024 / 1024);
> +
> +		if (bootverbose) {
> +			device_print_prettyname(dev);
> +			if (sc->stolen > 0)
> +				printf("detected %dk stolen memory, ", sc->stolen * 4);
> +			printf("aperture size is %dM\n", sc->initial_aperture / 1024 / 1024);
> +		}
>  
>  		/* GATT address is already in there, make sure it's enabled */
>  		pgtblctl = bus_read_4(sc->sc_res[0], AGP_I810_PGTBL_CTL);
-- 
Robert Noland <rnoland@FreeBSD.org>
FreeBSD




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1250160126.1823.11.camel>