Date: Sat, 6 Nov 1999 12:26:33 -0600 (CST) From: Steve Price <sprice@hiwaay.net> To: Nate Williams <nate@mt.sri.com> Cc: freebsd-current@FreeBSD.ORG Subject: Re: gzip(1) hanging Message-ID: <Pine.OSF.4.10.9911061224130.8338-100000@fly.HiWAAY.net> In-Reply-To: <199911061800.LAA24683@mt.sri.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Nov 1999, Nate Williams wrote:
# > I've got a -current box freshly CVSup'd and built from last
# > night that is exhibiting some rather bizarre behavior. I
# > actually noticed the problem on my Alpha package building
# > machine, but the same behavior exists on my i386 box.
# >
# > To see what I'm seeing (or maybe not :) all you have to do
# > is this:
# >
# > cd /usr/ports/graphics/jpeg
# > make extract
#
# Martin C. made a change to 'sh' yesterday with regards to
# file-descriptors that might have something to do with this...
Great catch Nate! The following patch fixes the problem that
I'm seeing and still addresses the problem Martin was trying to
fix as part of bin/14527.
Index: eval.c
===================================================================
RCS file: /home/ncvs/src/bin/sh/eval.c,v
retrieving revision 1.23
diff -u -r1.23 eval.c
--- eval.c 1999/11/05 12:06:30 1.23
+++ eval.c 1999/11/06 18:18:23
@@ -499,7 +499,7 @@
close(prevfd);
}
if (pip[1] >= 0) {
- if (!prevfd > 0)
+ if (prevfd < 0)
close(pip[0]);
if (pip[1] != 1) {
close(1);
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.OSF.4.10.9911061224130.8338-100000>