Date: Fri, 23 Aug 2013 23:00:12 +0000 From: "De La Gueronniere, Marc" <mdelagueronniere@verisign.com> To: Andre Oppermann <andre@freebsd.org> Cc: Juli Mallett <jmallett@freebsd.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Harika Tandra <htandra@gloriad.org>, "Miller, Vincent \(Rick\)" <vmiller@verisign.com> Subject: Re: Netmap ixgbe stripping Vlan tags Message-ID: <CE3D92C7.287AD%mdelagueronniere@verisign.com> In-Reply-To: <52176B3A.1040804@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_003_CE3D92C7287ADmdelagueronniereverisigncom_ Content-Type: text/plain; charset="us-ascii" Content-ID: <3120704F4910334BAAAAFD899A5AEC25@verisign.com> Content-Transfer-Encoding: quoted-printable On 8/23/13 4:01 PM, "Andre Oppermann" <andre@freebsd.org> wrote: >On 23.08.2013 15:12, Harika Tandra wrote: >> Hi all, >> >> I agree with Andre's statement >>> A netmap consumer >>> typically doesn't expect packets be mangled at all, mostly likely >>>netmap is >>> expressly used to get the packet exactly as they were seen on the wire. >> >> For my application I want to see the whole packet as is (as seen on the >>wire). >> I am sure it is important for many users who are interested in >> using netmap for speedup of packet capture in network >>security/monitoring applications. >> >> When I disable "vlanhwfilter" flag on the interface. It is behaving as >>expected and is >> not stripping the Vlan tags when placed in promiscuous mode. Netmap >>seems to be ignoring >> his setting or is resetting this option someplace (??). Any suggestion >>on where in Netmap >> code this maybe ? > >When you switch an interface to netmap mode it does a soft-reset first. >That reverts the vlanhwfilter configuration to default on. It's not >netmap that does it but the driver. It seems to happen in or around >ixgbe_setup_vlan_hw_support(). Hi all, I ran into this issue last week. We are using a vlan interface on top of an ixgbe interface in netmap mode. I think there are at least two separate problems: -ixgbe does not let you turn off vlan tag stripping (via ifconfig -vlanhwtag ). I am not completely sure this is a bug since vlanhwtag exact semantic is unclear to me. -In my opinion netmap should automatically disable vlan tag stripping and generation since it does not support carrying the 802.1q metadata over. I have a couple patches that I will be testing on Monday. See attachments. Marc > >--=20 >Andre > >_______________________________________________ >freebsd-net@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-net >To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" --_003_CE3D92C7287ADmdelagueronniereverisigncom_ Content-Type: application/octet-stream; name="0001-ixgbe-if-IFCAP_VLAN_HWTAGGING-is-not-set-actually-tu.patch" Content-Description: 0001-ixgbe-if-IFCAP_VLAN_HWTAGGING-is-not-set-actually-tu.patch Content-Disposition: attachment; filename="0001-ixgbe-if-IFCAP_VLAN_HWTAGGING-is-not-set-actually-tu.patch"; size=1224; creation-date="Fri, 23 Aug 2013 23:00:12 GMT"; modification-date="Fri, 23 Aug 2013 23:00:12 GMT" Content-ID: <E2AE5F3119E46448AAF31034C19586C2@verisign.com> Content-Transfer-Encoding: base64 RnJvbSBjZDdmMTQ1Y2E4MDI4YmY4N2JhYzYxMTNlYTVhZTQ3NTI1ZjQ4YzBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjIGRlIGxhIEd1ZXJvbm5pZXJlIDxtZGVsYWd1ZXJvbm5p ZXJlQHZlcmlzaWduLmNvbT4KRGF0ZTogVGh1LCAyMiBBdWcgMjAxMyAxOTo1NjowNSArMDAwMApT dWJqZWN0OiBbUEFUQ0ggMS8yXSBpeGdiZTogaWYgSUZDQVBfVkxBTl9IV1RBR0dJTkcgaXMgbm90 IHNldCBhY3R1YWxseSB0dXJuIG9mZiB2bGFuIHRhZyBzdHJpcHBpbmcuCgotLS0KIHN5cy9kZXYv aXhnYmUvaXhnYmUuYyB8ICAgIDYgKysrKystCiAxIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zeXMvZGV2L2l4Z2JlL2l4Z2JlLmMg Yi9zeXMvZGV2L2l4Z2JlL2l4Z2JlLmMKaW5kZXggZmNmNWI2Yi4uNDQ4M2U0NSAxMDA2NDQKLS0t IGEvc3lzL2Rldi9peGdiZS9peGdiZS5jCisrKyBiL3N5cy9kZXYvaXhnYmUvaXhnYmUuYwpAQCAt NDgxMSw2ICs0ODExLDggQEAgaXhnYmVfc2V0dXBfdmxhbl9od19zdXBwb3J0KHN0cnVjdCBhZGFw dGVyICphZGFwdGVyKQogCSovCiAJaWYgKGFkYXB0ZXItPm51bV92bGFucyA9PSAwKQogCQlyZXR1 cm47CisJY29uc3QgYm9vbCBod3N0cmlwID0gISEoaWZwLT5pZl9jYXBlbmFibGUgJiBJRkNBUF9W TEFOX0hXVEFHR0lORyk7CisKIAogCS8qCiAJKiogQSBzb2Z0IHJlc2V0IHplcm8ncyBvdXQgdGhl IFZGVEEsIHNvCkBAIC00ODI3LDEwICs0ODI5LDEyIEBAIGl4Z2JlX3NldHVwX3ZsYW5faHdfc3Vw cG9ydChzdHJ1Y3QgYWRhcHRlciAqYWRhcHRlcikKIAkJY3RybCAmPSB+SVhHQkVfVkxOQ1RSTF9D RklFTjsKIAkJY3RybCB8PSBJWEdCRV9WTE5DVFJMX1ZGRTsKIAl9Ci0JaWYgKGh3LT5tYWMudHlw ZSA9PSBpeGdiZV9tYWNfODI1OThFQikKKwlpZiAoaHctPm1hYy50eXBlID09IGl4Z2JlX21hY184 MjU5OEVCICYmIGh3c3RyaXApCiAJCWN0cmwgfD0gSVhHQkVfVkxOQ1RSTF9WTUU7CiAJSVhHQkVf V1JJVEVfUkVHKGh3LCBJWEdCRV9WTE5DVFJMLCBjdHJsKTsKIAorCWlmICghaHdzdHJpcCkKKwkJ cmV0dXJuOwogCS8qIFNldHVwIHRoZSBxdWV1ZXMgZm9yIHZsYW5zICovCiAJZm9yIChpbnQgaSA9 IDA7IGkgPCBhZGFwdGVyLT5udW1fcnhfcXVldWVzOyBpKyspIHsKIAkJcnhyID0gJmFkYXB0ZXIt PnJ4X3JpbmdzW2ldOwotLSAKMS43LjQuMQoK --_003_CE3D92C7287ADmdelagueronniereverisigncom_ Content-Type: application/octet-stream; name="0002-Force-VLAN_HWTAGGING-off-in-Netmap-mode.patch" Content-Description: 0002-Force-VLAN_HWTAGGING-off-in-Netmap-mode.patch Content-Disposition: attachment; filename="0002-Force-VLAN_HWTAGGING-off-in-Netmap-mode.patch"; size=788; creation-date="Fri, 23 Aug 2013 23:00:12 GMT"; modification-date="Fri, 23 Aug 2013 23:00:12 GMT" Content-ID: <928AB8B0EB0433418B7D92E2732653AD@verisign.com> Content-Transfer-Encoding: base64 RnJvbSA2OTlhZjFjZjU5NmE5OTllZDY0M2RhOGI2MGNkZDhjM2YwZTVmZTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjIGRlIGxhIEd1ZXJvbm5pZXJlIDxtZGVsYWd1ZXJvbm5p ZXJlQHZlcmlzaWduLmNvbT4KRGF0ZTogRnJpLCAyMyBBdWcgMjAxMyAyMDo0MDo1MyArMDAwMApT dWJqZWN0OiBbUEFUQ0ggMi8yXSBGb3JjZSBWTEFOX0hXVEFHR0lORyBvZmYgaW4gTmV0bWFwIG1v ZGUKCi0tLQogc3lzL2Rldi9peGdiZS9peGdiZS5jIHwgICAgMyArKy0KIDEgZmlsZXMgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3N5cy9kZXYv aXhnYmUvaXhnYmUuYyBiL3N5cy9kZXYvaXhnYmUvaXhnYmUuYwppbmRleCA0NDgzZTQ1Li44NGFi ZjE5IDEwMDY0NAotLS0gYS9zeXMvZGV2L2l4Z2JlL2l4Z2JlLmMKKysrIGIvc3lzL2Rldi9peGdi ZS9peGdiZS5jCkBAIC00ODExLDcgKzQ4MTEsOCBAQCBpeGdiZV9zZXR1cF92bGFuX2h3X3N1cHBv cnQoc3RydWN0IGFkYXB0ZXIgKmFkYXB0ZXIpCiAJKi8KIAlpZiAoYWRhcHRlci0+bnVtX3ZsYW5z ID09IDApCiAJCXJldHVybjsKLQljb25zdCBib29sIGh3c3RyaXAgPSAhIShpZnAtPmlmX2NhcGVu YWJsZSAmIElGQ0FQX1ZMQU5fSFdUQUdHSU5HKTsKKwljb25zdCBib29sIGh3c3RyaXAgPSAoaWZw LT5pZl9jYXBlbmFibGUgJiBJRkNBUF9WTEFOX0hXVEFHR0lORykKKwkJJiYgIShpZnAtPmlmX2Nh cGVuYWJsZSAmIElGQ0FQX05FVE1BUCk7CiAKIAogCS8qCi0tIAoxLjcuNC4xCgo= --_003_CE3D92C7287ADmdelagueronniereverisigncom_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CE3D92C7.287AD%mdelagueronniere>