Date: Mon, 14 Jul 2014 18:42:36 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 191673] [ staging ] www/squid32 Message-ID: <bug-191673-13-pyftDii0ZR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191673-13@https.bugs.freebsd.org/bugzilla/> References: <bug-191673-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191673 --- Comment #5 from Dan Lukes <dan@obluda.cz> --- http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html claim the @sample construct can be used for .sample suffix. Squid is using .default suffix so I followed the workaround mentioned on the same page. I don't know why the maintainer user the .default suffix, I just followed the porters handbook and handled the particular case the recommended way. Well, I'm not so familiar with the new @sample construct, so I didn't used it even in some cases it can be used, but it's not the case of this PR. According inline patches. I followed the latest revision of http://www.freebsd.org/doc/en/articles/problem-reports/article.html#pr-writing-sending Once more I followed document (current version of document) found on www.freebsd.org And again, you consider it to be wrong decision. OK. I'm not experienced port maintainer. I would be happy of someone else, more skilled, will provide better quality patches to you. I tried to save the ports I wish they should be saved, but nobody is going to take the job. I spend time to learn how to do it and I did it the recommended way. And it's considered wrong way. I understand you are volunteer and it would be better to have patch attached than inlined. Be sure I recognize it apply apply even in the case the processing of inline patch will take just few seconds more. I have no copy of patches already sent, so I can't attach them again even as favor. I explained it already. I wished that even less-than-excelent (but still working well) patch is more helpful than no patch at all. But I'm not in the position to decide, it's commiters your job. Don't misunderstand me, please, I'm listening to all the advices you kindly offered to me, but I really have no sufficient spare time to become #1 expert in this area. Especially in the case it's wrong way to follow published handbooks. If you are unable to use my PRs, either because you are unable extract the patch or because the patch is so low quality, then close the PR, please. May be someone else will take the job and do it better than me. Cheers Dan -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191673-13-pyftDii0ZR>