Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Apr 2008 12:31:36 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        roberto@FreeBSD.org, ports@FreeBSD.org
Subject:   Re: devel/mercurial is not usable on -CURRENT after /src/sys/sys/fcntl.h changes
Message-ID:  <20080418093136.GC18958@deviant.kiev.zoral.com.ua>
In-Reply-To: <20080418085041.GA44025@underworld.novel.ru>
References:  <20080418085041.GA44025@underworld.novel.ru>

next in thread | previous in thread | raw e-mail | index | archive | help

--dEhLd0jN5MocHkcT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 18, 2008 at 12:50:41PM +0400, Roman Bogorodskiy wrote:
> Hello,
>=20
> devel/mercurial is not usable on -CURRENT after /src/sys/sys/fcntl.h
> changes[1].
>=20
> It compiles alright, but fails to start with the following message:
>=20
> ImportError: /usr/local/lib/python2.5/site-packages/mercurial/osutil.so:
> Undefined symbol "fdopendir"
>=20
> since we don't have fdopendir() implemented in FreeBSD.
>=20
> osutil.c contains the following code:
>=20
> #ifdef AT_SYMLINK_NOFOLLOW
>         dfd =3D open(path, O_RDONLY);
>         dir =3D fdopendir(dfd);
> #else  =20
>         dir =3D opendir(path);
>         dfd =3D -1;
> #endif
>=20
> So the problem didn't show up because AT_SYMLINK_NOFOLLOW was not
> defined,  but after the change in fcntl.h mentioned above it got broken.
>=20
> 1: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/fcntl.h.diff?r1=3D1.=
19;r2=3D1.20;f=3Dh
>=20
> Roman Bogorodskiy

fdopendir() was committed several days ago. Anyway, the check in the
cited source is obviously broken.

--dEhLd0jN5MocHkcT
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (FreeBSD)

iEYEARECAAYFAkgIancACgkQC3+MBN1Mb4hRBACgo5cbUnvNbMUxYyrSA8PqMDmH
qOYAoK4R2FKwFAnqvgfZS3oEEOJ9ojP+
=E0dE
-----END PGP SIGNATURE-----

--dEhLd0jN5MocHkcT--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080418093136.GC18958>