Date: Wed, 30 Apr 2003 11:08:32 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Luigi Rizzo <rizzo@icir.org> Cc: freebsd-net@freebsd.org Subject: Re: IPDIVERT Message-ID: <20030430080832.GB39766@sunbay.com> In-Reply-To: <20030430004245.B95389@xorpc.icir.org> References: <20030430023640.A22257@iclub.nsu.ru> <20030429200529.GA71528@sunbay.com> <20030430143114.A38982@iclub.nsu.ru> <20030430004245.B95389@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--UFHRwCdBEJvubb2X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 30, 2003 at 12:42:45AM -0700, Luigi Rizzo wrote: > On Wed, Apr 30, 2003 at 02:31:14PM +0700, Max Khon wrote: > > hi, there! > ... > > On Tue, Apr 29, 2003 at 11:05:29PM +0300, Ruslan Ermilov wrote: > > > > I have a suggestion to build GENERIC and ipfw.ko with IPDIVERT by d= efault > > > > or change IPDIVERT to NOIPDIVERT and build boot kernels with NOIPDI= VERT. > > > > The main goal is to allow to use NAT with stock kernels and ipfw.ko. > ... > > AFAIK there is no possibility to add IPPROTO_DIVERT dynamically to > > inetsw[]. Some fields of 'struct ipq' are under #ifdef IPDIVERT as well. > > ipfw code under #ifdef IPDIVERT are just `case' labels and strings in p= rintf's > > (like "ipdivert enabled"). In other words is it really > > worth splitting ipdivert into separate .ko module? Changing IPDIVERT to > > NOIPDIVERT will be cleaner in my opinion. >=20 > indeed, i believe we should make the main part of IPDIVERT processing > (in ip_input.c, ip_output.c, ip_fw2.c and ip_var.h) non-optional > (this would also allow a better realignment of fields in struct ipq)=20 > and only make the code in ip_divert.c a module >=20 That's what I basically meant by "changing lot of ``#ifdef IPDIVERT'' to ``if (IPDIVERT_LOADED)''", too. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --UFHRwCdBEJvubb2X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+r4SAUkv4P6juNwoRAox2AJ9yKTveG3rl7nDLgVXtpA5zyd3akQCeOGEx unhRKpLdVs2/Ig1kSCBAEbs= =wV+p -----END PGP SIGNATURE----- --UFHRwCdBEJvubb2X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030430080832.GB39766>