Date: Mon, 18 Jul 2016 22:13:31 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302985 - head/sys/geom/label Message-ID: <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> In-Reply-To: <CAH7qZftQg4TDyGC_kMPVcHpinK_Q_JvKZ-uQXzim16SOFnw%2BPQ@mail.gmail.com> References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> <CAH7qZftQg4TDyGC_kMPVcHpinK_Q_JvKZ-uQXzim16SOFnw%2BPQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q Content-Type: multipart/mixed; boundary="CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> Subject: Re: svn commit: r302985 - head/sys/geom/label References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> <CAH7qZftQg4TDyGC_kMPVcHpinK_Q_JvKZ-uQXzim16SOFnw+PQ@mail.gmail.com> In-Reply-To: <CAH7qZftQg4TDyGC_kMPVcHpinK_Q_JvKZ-uQXzim16SOFnw+PQ@mail.gmail.com> --CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 18.07.16 17:24, Maxim Sobolev wrote: > Andrey, are you talking about this: >=20 > --- > r156299 | pjd | 2006-03-04 11:41:54 -0800 (=D1=81=D0=B1, 04 =D0=BC=D0=B0= =D1=80 2006) | 11 lines >=20 > We need to check if file system size is equal to provider's size, becau= se > sysinstall(8) still bogusly puts first partition at offset 0 instead of= 16, > so glabel/ufs will find file system on slice instead of partition. >=20 > Before sysinstall is fixed, we must keep this code, which means that we= > wont't be able to detect UFS file systems created with 'newfs -s ...'. >=20 > PS. bsdlabel(8) creates partitions properly. >=20 > MFC after: 3 days > --- >=20 > In which case this particular change has a better chance of working > since it's not removing this check but making it less strict. Therefore= > it might attach to a wrong provider only if first UFS slice is the only= > one slice on partition (or if the other partition is very small - less > than 256 blocks in size). In either of those cases I don't think it > makes much difference if we are attaching to a slice or a partition. No, I mean r235918, that was reverted after several complains. UFS label is a special label. It always had the same size that provider. Now it will attach to first provider that will be tasted. It can be gmirror, generic glabel, geli, gpart, mbr, whole disk. https://lists.freebsd.org/pipermail/freebsd-geom/2009-April/003473.html --=20 WBR, Andrey V. Elsukov --CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq-- --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEvBAEBCAAZBQJXjSpcEhxidTdjaGVyQHlhbmRleC5ydQAKCRABxeoEEMihejOx B/9DwDnHZOgrc/BmUPhgptCCCJR9ZElPnKvqqCQrO4hwLaOhaAHRSD/FwV3168eD Nd8YQn3rK5Sx8oEgDtEymzp0y/crCRmX7d5fbliqPW3atvlNVzEhPEvGByLbW06s Tg11jLnjQLwFAYrf5JQZU5h68nVggRNSJ2T1e6ZTl/pdFbblxViXkLfvVeGdieKP edtnIb37lNzsoLpniwfibRFB5iXGWE0YDQC7cSfYuDQXw/1/TMV6W3xZrXwk77/r uF+5nqXc3zpzoMrGMyenBC7PrCKRbJ46IOMHsXBM2hO+Y0NrOHjLr1Don4Lp16EI FdHOTBffUR8xRgfJ+LuAxVQ5 =toTJ -----END PGP SIGNATURE----- --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61cba001-2717-49ee-843e-5ed6d18fa17b>