Date: Thu, 14 Feb 2013 22:05:56 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: Marc Fournier <scrappy@hub.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, freebsd-stable@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: 9-STABLE -> NFS -> NetAPP: Message-ID: <1964289267.3041689.1360897556427.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <9A149E78-BB4F-414D-AAE5-331C5934FF82@hub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_3041688_1205401174.1360897556425 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marc Fournier wrote: > On 2013-02-13, at 3:54 PM, Rick Macklem <rmacklem@uoguelph.ca> wrote: >=20 > >> > > The pid that is in "T" state for the "ps auxlH". >=20 > Different server, last kernel update on Jan 22nd, https process this > time instead of du last time. >=20 > I've attached: >=20 > ps auxlH > ps auxlH of just the processes that are in TJ state (6 httpd servers) > procstat output for each of the 6 process >=20 >=20 >=20 >=20 > They are included as attachments =E2=80=A6 if these don't make it through= , let > me know, just figured I'd try and keep it compact ... Well, I've looked at this call path a little closer: 16693 104135 httpd - mi_switch+0x186 thread_suspe= nd_check+0x19f sleepq_catch_signals+0x1c5 sleepq_timedwait_sig+0x19 _sleep+0x2ca clnt_vc_call+0x763 clnt_reconnect_= call+0xfb newnfs_request+0xadb nfscl_request+0x72 nfsrpc_accessrpc+0x1df nfs34_access_otw+0x56 nfs_acces= s+0x306 vn_open_cred+0x5a8 kern_openat+0x20a amd64_syscall+0x540 Xfast_syscall+0xf7=20 I am probably way off, since I am not familiar with this stuff, but it seems to me that thread_suspend_check() should just return 0 for the case where stop_allowed =3D=3D SIG_STOP_NOT_ALLOWED (TDF_SBDRY flag set) instead of sitting in the loop and doing a mi_switch(). I'm not even sure if it should call thread_suspend_check() for this case, but there are cases in thread_suspend_check() that I don't understand. Although I don't really understand thread_suspend_check(), I've attached a simple patch that might be a starting point for fixing this? I wouldn't recommend trying the patch until kib and/or jhb weigh in on whether it makes any sense. rick ------=_Part_3041688_1205401174.1360897556425 Content-Type: text/x-patch; name=sigstop.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=sigstop.patch LS0tIGtlcm4vc3Vicl9zbGVlcHF1ZXVlLmMuc2F2CTIwMTMtMDItMTQgMjA6Mzk6NDcuMDAwMDAw MDAwIC0wNTAwCisrKyBrZXJuL3N1YnJfc2xlZXBxdWV1ZS5jCTIwMTMtMDItMTQgMjE6MDM6MDMu MDAwMDAwMDAwIC0wNTAwCkBAIC00NDMsNyArNDQzLDcgQEAgc2xlZXBxX2NhdGNoX3NpZ25hbHMo dm9pZCAqd2NoYW4sIGludCBwcgogCXNpZyA9IGN1cnNpZyh0ZCwgc3RvcF9hbGxvd2VkKTsKIAlp ZiAoc2lnID09IDApIHsKIAkJbXR4X3VubG9jaygmcHMtPnBzX210eCk7Ci0JCXJldCA9IHRocmVh ZF9zdXNwZW5kX2NoZWNrKDEpOworCQlyZXQgPSB0aHJlYWRfc3VzcGVuZF9jaGVjaygxLCBzdG9w X2FsbG93ZWQpOwogCQlNUEFTUyhyZXQgPT0gMCB8fCByZXQgPT0gRUlOVFIgfHwgcmV0ID09IEVS RVNUQVJUKTsKIAl9IGVsc2UgewogCQlpZiAoU0lHSVNNRU1CRVIocHMtPnBzX3NpZ2ludHIsIHNp ZykpCi0tLSBrZXJuL2tlcm5fZXhpdC5jLnNhdgkyMDEzLTAyLTE0IDIxOjA0OjIxLjAwMDAwMDAw MCAtMDUwMAorKysga2Vybi9rZXJuX2V4aXQuYwkyMDEzLTAyLTE0IDIxOjA0OjUwLjAwMDAwMDAw MCAtMDUwMApAQCAtMTU5LDcgKzE1OSw3IEBAIGV4aXQxKHN0cnVjdCB0aHJlYWQgKnRkLCBpbnQg cnYpCiAJCSAqIEZpcnN0IGNoZWNrIGlmIHNvbWUgb3RoZXIgdGhyZWFkIGdvdCBoZXJlIGJlZm9y ZSB1cy4KIAkJICogSWYgc28sIGFjdCBhcHByb3ByaWF0ZWx5OiBleGl0IG9yIHN1c3BlbmQuCiAJ CSAqLwotCQl0aHJlYWRfc3VzcGVuZF9jaGVjaygwKTsKKwkJdGhyZWFkX3N1c3BlbmRfY2hlY2so MCwgU0lHX1NUT1BfQUxMT1dFRCk7CiAKIAkJLyoKIAkJICogS2lsbCBvZmYgdGhlIG90aGVyIHRo cmVhZHMuIFRoaXMgcmVxdWlyZXMKLS0tIGtlcm4va2Vybl9zaWcuYy5zYXYJMjAxMy0wMi0xNCAy MTowNTowNi4wMDAwMDAwMDAgLTA1MDAKKysrIGtlcm4va2Vybl9zaWcuYwkyMDEzLTAyLTE0IDIx OjA1OjQwLjAwMDAwMDAwMCAtMDUwMApAQCAtMTQ2Myw3ICsxNDYzLDcgQEAga2Vybl9zaWdzdXNw ZW5kKHN0cnVjdCB0aHJlYWQgKnRkLCBzaWdzZQogCQl3aGlsZSAobXNsZWVwKCZwLT5wX3NpZ2Fj dHMsICZwLT5wX210eCwgUFBBVVNFfFBDQVRDSCwgInBhdXNlIiwKIAkJCTApID09IDApCiAJCQkv KiB2b2lkICovOwotCQl0aHJlYWRfc3VzcGVuZF9jaGVjaygwKTsKKwkJdGhyZWFkX3N1c3BlbmRf Y2hlY2soMCwgU0lHX1NUT1BfQUxMT1dFRCk7CiAJCW10eF9sb2NrKCZwLT5wX3NpZ2FjdHMtPnBz X210eCk7CiAJCXdoaWxlICgoc2lnID0gY3Vyc2lnKHRkLCBTSUdfU1RPUF9BTExPV0VEKSkgIT0g MCkKIAkJCWhhc19zaWcgKz0gcG9zdHNpZyhzaWcpOwotLS0ga2Vybi9rZXJuX3RocmVhZC5jLnNh dgkyMDEzLTAyLTE0IDIxOjA3OjA2LjAwMDAwMDAwMCAtMDUwMAorKysga2Vybi9rZXJuX3RocmVh ZC5jCTIwMTMtMDItMTQgMjE6NDQ6MTAuMDAwMDAwMDAwIC0wNTAwCkBAIC03NjIsNyArNzYyLDcg QEAgc3RvcG1lOgogICogcmV0dXJuX2luc3RlYWQgaXMgc2V0LgogICovCiBpbnQKLXRocmVhZF9z dXNwZW5kX2NoZWNrKGludCByZXR1cm5faW5zdGVhZCkKK3RocmVhZF9zdXNwZW5kX2NoZWNrKGlu dCByZXR1cm5faW5zdGVhZCwgaW50IHN0b3BfYWxsb3dlZCkKIHsKIAlzdHJ1Y3QgdGhyZWFkICp0 ZDsKIAlzdHJ1Y3QgcHJvYyAqcDsKQEAgLTc5NCw2ICs3OTQsOSBAQCB0aHJlYWRfc3VzcGVuZF9j aGVjayhpbnQgcmV0dXJuX2luc3RlYWQpCiAJCSAgICAocC0+cF9mbGFnICYgUF9TSU5HTEVfQk9V TkRBUlkpICYmIHJldHVybl9pbnN0ZWFkKQogCQkJcmV0dXJuIChFUkVTVEFSVCk7CiAKKwkJaWYg KHN0b3BfYWxsb3dlZCA9PSBTSUdfU1RPUF9OT1RfQUxMT1dFRCAmJiByZXR1cm5faW5zdGVhZCkK KwkJCXJldHVybiAoMCk7CisKIAkJLyoKIAkJICogSWYgdGhlIHByb2Nlc3MgaXMgd2FpdGluZyBm b3IgdXMgdG8gZXhpdCwKIAkJICogdGhpcyB0aHJlYWQgc2hvdWxkIGp1c3Qgc3VpY2lkZS4KLS0t IGtlcm4vc3Vicl90cmFwLmMuc2F2CTIwMTMtMDItMTQgMjE6MDk6NDMuMDAwMDAwMDAwIC0wNTAw CisrKyBrZXJuL3N1YnJfdHJhcC5jCTIwMTMtMDItMTQgMjE6MTA6MDIuMDAwMDAwMDAwIC0wNTAw CkBAIC0yODMsNyArMjgzLDcgQEAgYXN0KHN0cnVjdCB0cmFwZnJhbWUgKmZyYW1lcCkKIAkgKi8K IAlpZiAoZmxhZ3MgJiBUREZfTkVFRFNVU1BDSEspIHsKIAkJUFJPQ19MT0NLKHApOwotCQl0aHJl YWRfc3VzcGVuZF9jaGVjaygwKTsKKwkJdGhyZWFkX3N1c3BlbmRfY2hlY2soMCwgU0lHX1NUT1Bf QUxMT1dFRCk7CiAJCVBST0NfVU5MT0NLKHApOwogCX0KIAotLS0gc3lzL3Byb2MuaC5zYXYJMjAx My0wMi0xNCAyMToxMDo1OC4wMDAwMDAwMDAgLTA1MDAKKysrIHN5cy9wcm9jLmgJMjAxMy0wMi0x NCAyMToxMjowMS4wMDAwMDAwMDAgLTA1MDAKQEAgLTk0Myw3ICs5NDMsNyBAQCB2b2lkCXRocmVh ZF9zdG9wcGVkKHN0cnVjdCBwcm9jICpwKTsKIHZvaWQJY2hpbGRwcm9jX3N0b3BwZWQoc3RydWN0 IHByb2MgKmNoaWxkLCBpbnQgcmVhc29uKTsKIHZvaWQJY2hpbGRwcm9jX2NvbnRpbnVlZChzdHJ1 Y3QgcHJvYyAqY2hpbGQpOwogdm9pZAljaGlsZHByb2NfZXhpdGVkKHN0cnVjdCBwcm9jICpjaGls ZCk7Ci1pbnQJdGhyZWFkX3N1c3BlbmRfY2hlY2soaW50IGhvdyk7CitpbnQJdGhyZWFkX3N1c3Bl bmRfY2hlY2soaW50IGhvdywgaW50IHN0b3BfYWxsb3dlZCk7CiB2b2lkCXRocmVhZF9zdXNwZW5k X3N3aXRjaChzdHJ1Y3QgdGhyZWFkICopOwogdm9pZAl0aHJlYWRfc3VzcGVuZF9vbmUoc3RydWN0 IHRocmVhZCAqdGQpOwogdm9pZAl0aHJlYWRfdW5saW5rKHN0cnVjdCB0aHJlYWQgKnRkKTsK ------=_Part_3041688_1205401174.1360897556425--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1964289267.3041689.1360897556427.JavaMail.root>