Date: Wed, 5 Dec 2007 02:50:02 GMT From: Eric van Gyzen <eric+fbports@vangyzen.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/118358: math/R update from 2.6.0 to 2.6.1 version Message-ID: <200712050250.lB52o2TT019436@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/118358; it has been noted by GNATS. From: Eric van Gyzen <eric+fbports@vangyzen.net> To: bug-followup@FreeBSD.org, Vittorio De Martino <vdemart1@tin.it> Cc: Subject: Re: ports/118358: math/R update from 2.6.0 to 2.6.1 version Date: Tue, 04 Dec 2007 20:20:32 -0600 Vittorio, Thanks for your patch. It looks good, but I have some suggestions. The patch removes several %%FOO%% prefixes from the pkg-plist, such as: -%%TCLTK%%lib/R/library/tcltk/libs/tcltk.so +lib/R/library/tcltk/libs/tcltk.so The %%FOO%% prefixes exist to support the Makefile's OPTIONS; they should not be removed. See: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html There are a few @dirrm lines that should not change %%DOCSDIR%% to share/doc. The man pages need not be specified in the pkg-plist; the MAN1 variable in the Makefile handles them. Thanks for your work! I'll gladly review a revised patch. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712050250.lB52o2TT019436>