Date: Mon, 08 Apr 2013 13:14:25 -0700 From: Sean Bruno <seanwbruno@gmail.com> To: "FreeBSD-scsi@freebsd.org" <FreeBSD-scsi@freebsd.org> Subject: ciss(4) malformed vendor/product data Message-ID: <1365452066.2312.30.camel@localhost>
next in thread | raw e-mail | index | archive | help
--=-27lH1IcEQAXYb0GwDg0f
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
I think, at some point in the mists of time, vendor and product inquiry
were expand to 16bytes and 48 bytes respectively, at least when I look
at camcontrol, that's what I see.
I noted that the camcontrol devlist output was slightly mangled (note
the lack of 1+0):
-bash-4.2$ sudo camcontrol devlist
<COMPAQ RAID 1(1VOLUME OK> at scbus0 target 0 lun 0 (pass0,da0)
<COMPAQ RAID 1(1VOLUME OK> at scbus0 target 1 lun 0 (pass1,da1)
<TEAC CD-224E 9.9A> at scbus3 target 0 lun 0 (pass2,cd0)
When I updated this to have the same padded sizes as camcontrol, then
things realigned and became clear:
<COMPAQ RAID 1(1+0) OK> at scbus0 target 0 lun 0 (pass0,da0)
<COMPAQ RAID 0 OK> at scbus0 target 1 lun 0 (pass1,da1)
Not sure if there's a global that should be used here, or=20
/home/seanbru/ybsd_9/sys/dev/ciss/ciss.c
@@ -3351,8 +3351,8 @@
=20
cl =3D &sc->ciss_logical[bus][target];
=20
- padstr(inq->vendor, "COMPAQ", 8);
- padstr(inq->product,
ciss_name_ldrive_org(cl->cl_ldrive->fault_tolerance), 8);
+ padstr(inq->vendor, "COMPAQ", 16);
+ padstr(inq->product,
ciss_name_ldrive_org(cl->cl_ldrive->fault_tolerance), 48);
padstr(inq->revision,
ciss_name_ldrive_status(cl->cl_lstatus->status), 16);
}
}
--=-27lH1IcEQAXYb0GwDg0f
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iQEcBAABAgAGBQJRYyUhAAoJEBkJRdwI6BaH8icH/0AJMTBHxW/aszediOLgHOcQ
96pCkA9+yEsJbBOf7LM0HAswZccS9mtog99/htAYSrgr6BgBIApueNo+9K355p/u
Rk+zO0foHRss2uAbk6/x1sRYVyuh8jm2r3fRQydL+/uVaH8DsfCHHNy/140lv1Dd
W7CauLrGVCXrzZziV0PFQvYboDj2EPkACb/dqZIafp1UDxmpWZRdllVlDW9GV5YV
Ayp76D/AQCneYtuRs/NCQvQiy+Ut7K/aZceYNhxwtlAhJ0svtGPXQEEHwRkBgkYy
yjHVp7XSicPRZCzsqagtYQoPOuTySHLwsotTVPagjTd9yYRtjMLIlzGO+XiyyRw=
=r917
-----END PGP SIGNATURE-----
--=-27lH1IcEQAXYb0GwDg0f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1365452066.2312.30.camel>