Date: Wed, 6 Sep 2000 14:45:53 -0400 (EDT) From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_divert.c ip_icmp.c ip_input.c ip_mroute.c ip_output.c raw_ip.c udp_usrreq.c Message-ID: <200009061845.OAA20964@khavrinen.lcs.mit.edu> In-Reply-To: <200009011233.FAA69145@freefall.freebsd.org> References: <200009011233.FAA69145@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
<<On Fri, 1 Sep 2000 05:33:06 -0700 (PDT), Ruslan Ermilov <ru@FreeBSD.org> said: > o ip_output() now expects all three fields, ip_len, ip_off and (what is > significant) ip_id in host byte order. It was a headache for years that > ip_id was handled differently. The only compatibility issue here is the > raw IP socket interface with IP_HDRINCL socket option set and a non-zero > ip_id field, but ip.4 manual page was unclear on whether in this case > ip_id field should be in host or network byte order. According to Mike Karels (in a message to me dated 2 June 1997), BSD/OS leaves the ip_id field in network order all the time, but swaps in the raw IP code to preserve the old interface. There is never any arithmetic performed on the IP ID, only comparisons for equality, so leaving out the swap should save a cycle or three. -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009061845.OAA20964>