Date: Wed, 30 Oct 2013 10:32:19 -0400 From: Eitan Adler <lists@eitanadler.com> To: Gabor Pali <pgj@freebsd.org> Cc: Dominic Fandrey <kamikaze@bsdforen.de>, Baptiste Daroussin <bapt@freebsd.org>, Michael Gmelin <freebsd@grem.de>, marino@freebsd.org, lukasz@wasikowski.net, FreeBSD Ports <ports@freebsd.org> Subject: Re: State of the Porters' Handbook Message-ID: <CAF6rxg=z%2BT3022cKUQs5THvq2w0K9DzAuxi%2B57AR6cXhVopzUA@mail.gmail.com> In-Reply-To: <CAHnG2CzjbqAWJr5dBACvYG3a=vxGas_fD=eoHH8egHZ%2BhD%2BcoQ@mail.gmail.com> References: <526E272D.3040607@marino.st> <526E2E8D.3020109@bsdforen.de> <526E2FB8.5060906@marino.st> <526E3454.60501@bsdforen.de> <526E3685.4070306@marino.st> <526E3986.7050304@bsdforen.de> <526E3BC2.6030004@marino.st> <526E3F32.2040704@bsdforen.de> <20131028145645.GE74512@ithaqua.etoilebsd.net> <20131028160458.5f7add4c@bsd64.grem.de> <20131028151145.GF74512@ithaqua.etoilebsd.net> <CAHnG2CzjbqAWJr5dBACvYG3a=vxGas_fD=eoHH8egHZ%2BhD%2BcoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 29, 2013 at 5:02 PM, Gabor Pali <pgj@freebsd.org> wrote: > On Mon, Oct 28, 2013 at 4:11 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: >> I do buy this argument :) and I'll see want I can do for that in the next couple >> of days. > > Please find a patch [1] (and see [2] for the HTML preview) for the > porters-handbook document to address this problem. Note that some of > the contents have been already updated by Eitan Adler, this is just a > continuation of the work. > > [1] http://people.freebsd.org/~pgj/patches/2013/10/29/porters-handbook.staging.diff > [2] http://people.freebsd.org/~pgj/patches/2013/10/29/porters-handbook-staging/ Hi, nice work. Very quick review: <step> - <para><command>make reinstall</command></para> - </step> + <para><command>pkg_add <replaceable>package-name</replaceable></command></para> - <step> - <para><command>make package</command></para> + <para>Or, in case of <emphasis>pkgng</emphasis>:</para> + + <para><command>pkg add <replaceable>package-name</replaceable></command></para> </step> We generally don't refer to pkgng in the docs: please use "pkg". Further, I'd put the pkg cases first as the pkg_ tools are deprecated. + <application>poudriere</application>. These maintain Thanks for adding this. + <para>For ports that install kernel modules, the This should be in a different section specifically about kernel modules. + staging) but it is broken (Mailman up to 2.1.16, for instance). I would not mention specific ports here. Examples get old quick. This looks good overall and thanks for working on it. -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=z%2BT3022cKUQs5THvq2w0K9DzAuxi%2B57AR6cXhVopzUA>