Date: Sat, 3 Feb 2007 01:52:12 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount Makefile mount.c Message-ID: <20070203005212.GE25236@garage.freebsd.pl> In-Reply-To: <20070203002519.GA1517@crodrigues.org> References: <200702022358.l12NwAlV049192@repoman.freebsd.org> <20070202235942.GC25236@garage.freebsd.pl> <20070203002519.GA1517@crodrigues.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--sfyO1m2EN8ZOtJL6 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 02, 2007 at 07:25:19PM -0500, Craig Rodrigues wrote: > On Sat, Feb 03, 2007 at 12:59:43AM +0100, Pawel Jakub Dawidek wrote: > > Should we also restart mountd(8) on successful umount(8)? >=20 > Your fix to mount(8) is a good one, since the existing behavior > of mount(8) is to SIGHUP mountd, based on the pid=20 > in /var/run/mountd.pid. >=20 > I don't like how these sneaky behaviors with non-obvious side-effects > sneak into existing utilities like mount(8).....but that's what we have > today. >=20 > A sneaky side effect of the existing behavior, is that when you > SIGHUP mountd, it deletes all existing NFS exports, re-reads > /etc/exports, and then re-creates all the NFS exports. > Some people find this very annoying, especially when you > are already using an NFS export ( http://www.freebsd.org/cgi/query-pr.cgi= ?pr=3Dkern/9619 ). >=20 > I am looking at some patches from Andrey Simonenko which fix this > problem, but they are quite intrusive changes to userland and kernel, > so it is slow going on my part. >=20 > So for now, I would recommend leaving umount alone, to avoid adding > new side effects, even though based on existing behavior, it seems logical > to add it. >=20 > However, if this behavior is necessary for ZFS, then I won't oppose > modifying umount to SIGHUP mountd. :) >=20 > It seems a lot of cruft has accumulated in a simple utility like > mount(8) over the years! I also was surprised when I found what mount(8) is doing with mountd(8). I don't like this behaviour, but well. What I think we should do on SIGHUP is to create new exports list from the given files, and compare all entries with the entries we got already. Based on that comparsion we can only remove entires which disappeared or changed and add entries which were added or changed. Will it be hard to implement something like this or am I missing something? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --sfyO1m2EN8ZOtJL6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFw9y8ForvXbEpPzQRAtK0AKDPdpVoEgNol7IYSBH8IqVR+44RUgCg9NqN /7ENQa+/NZdP4lBExQ0uuVs= =4hiA -----END PGP SIGNATURE----- --sfyO1m2EN8ZOtJL6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070203005212.GE25236>