Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jun 2010 11:27:21 -0700
From:      Garrett Cooper <gcooper@FreeBSD.org>
To:        Andrius Morkunas <andrius@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 179675 for review
Message-ID:  <AANLkTilmvDwJlMfH6XwIMu0V4oS-RkotnDVpFLbLhnmp@mail.gmail.com>
In-Reply-To: <201006161148.o5GBmrDq093951@repoman.freebsd.org>
References:  <201006161148.o5GBmrDq093951@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 16, 2010 at 4:48 AM, Andrius Morkunas <andrius@freebsd.org> wro=
te:
> http://p4web.freebsd.org/@@179675?ac=3D10
>
> Change 179675 by andrius@klevas on 2010/06/16 11:48:11
>
> =A0 =A0 =A0 =A0Add NO_USE_CC.
>
> =A0 =A0 =A0 =A0If defined, NO_USE_CC forces USE_CC and USE_GCC to be igno=
red.
> =A0 =A0 =A0 =A0Before, there was no way to NOT respect USE_CC/USE_GCC var=
iables.
>
> Affected files ...
>
> .. //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk#2 edit
>
> Differences ...
>
> =3D=3D=3D=3D //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk=
#2 (text+ko) =3D=3D=3D=3D
>
> @@ -3,6 +3,11 @@
> =A0# PORTS_CXX should only be set if PORTS_CC is neither gcc nor clang
> =A0PORTS_CXX?=3D =A0 =A0g++
>
> +.if defined(NO_USE_CC)
> +.undef USE_CC
> +.undef USE_GCC
> +.endif
> +
> =A0# Handle USE_CC
> =A0.if defined(USE_CC)
> =A0# Check if port requires specific compiler
> @@ -35,7 +40,6 @@
>
> =A0# Clang
> =A0.elif !empty(PORTS_CC:Mclang*)
> -# TODO: handle something like USE_CLANG here when/if there's need for th=
at
> =A0CC=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0clang
> =A0CXX=3D =A0 =A0 =A0 =A0 =A0 clang++
> =A0.else

Why not just check to see if CC is defined and empty?
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTilmvDwJlMfH6XwIMu0V4oS-RkotnDVpFLbLhnmp>