Date: Mon, 7 Nov 2005 15:10:32 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Ulf Lilleengen <lulf@kerneled.org> Cc: freebsd-hackers@freebsd.org Subject: Re: Contributing to FreeBSD list of things todo Message-ID: <20051107231032.GA5351@odin.ac.hmc.edu> In-Reply-To: <20051107225921.GA1623@samfundet.no> References: <a8b370910511011430v38ed6fe4xdd8b5ff5dec80939@mail.gmail.com> <20051101225848.GB20543@odin.ac.hmc.edu> <20051107225921.GA1623@samfundet.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2005 at 11:59:21PM +0100, Ulf Lilleengen wrote: > On Tue, Nov 01, 2005 at 02:58:48PM -0800, Brooks Davis wrote: > > On Tue, Nov 01, 2005 at 04:30:00PM -0600, Ben Siemon wrote: > > > I have a suggestion for things dev people could do to help out with > > > code already done. I noticed the suggestion for compiling with -Wall > > > enabled. Would it serve any purpose to compile the sources with -ansi > > > and or -pedantic as well? I am fairly new to FreeBSD so forgive me if > > > this has alread been addressed. > >=20 > > I think the todo list is dated in this area. We now compile many files > > with large sets of warning flags via the WARNS variable in Makefiles. > > It is useful to expand the coverage in this area, but it's not all that > > trivial. It's often fairly easy to make the warning go away without > > fixing the real problem the warning represented. This means that far > > too many patches to raise warning levels are useless and waste developer > > time. There's also the fact that such changes need to be tested on > > multiple architectures because certain warnings are platform specfic. > > At the least testing is needed on i386, alpha, and sparc. > >=20 > I've seen an effort to remove these warnings by setting WARNS?=3D6 . Would > this be preferable to work on, on freebsd as well? Ofcourse testing on > most architectures. Setting WARNS=3D higher and fixing the warning is useful, but we've see a lot of submissions that took more time to fix than dealing with the problem would have in the first place. The work of someone who submitted high-quality fixes consistantly, would certainly be appreciated. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDb97jXY6L6fI4GtQRAspzAKDi+B74FLjDWAwtWPi+j/jBhU2uxwCgpfFb H6eI5SUiQbUL5jQQEJWSnzY= =whoh -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051107231032.GA5351>