Date: Fri, 01 Apr 2011 11:42:56 -0700 From: Patrick Mahan <mahan@mahan.org> To: freebsd-mips@freebsd.org Subject: Re: Blatant simple bug in Cavium SDK USB code? Message-ID: <4D961CB0.6080802@mahan.org> In-Reply-To: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C7@EMBX01-WF.jnpr.net> References: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C5@EMBX01-WF.jnpr.net> <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C7@EMBX01-WF.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/1/11 11:08 AM, Andrew Duane wrote: > > In the routine cvmx_usb_initialize in sys/contrib/octeon-sdk/cvmx-usb.c, I'm pretty sure there's a silly little bug that really BADLY breaks the USB driver for some of us. > > Near the top, after it finds board type and sets the clock type, as part of the structure initialization, there is: > > memset(usb, 0, sizeof(usb)); > > Tell me that is not supposed to be: > > memset(usb, 0, sizeof(*usb)); > > The existing code only zeros 4/8 bytes, instead of the 23KB of the structure. > Ugh... Looks like this is an original bug from Cavium. No wonder I always had issues working with the USB in u-boot off of the SDK. I see this is my 1.9 Cavium SDK. Not sure if it is on a more recent version. Patrick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D961CB0.6080802>