Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Jun 2003 00:29:04 -0400
From:      Chuck Swiger <cswiger@mac.com>
To:        freebsd-stable@freebsd.org
Subject:   Re: dvd+rw-tools ported to FreeBSD (Sony 500A DVD[+/-]R[W] support)
Message-ID:  <3EED4790.6060302@mac.com>
In-Reply-To: <200306152351.h5FNptsC011948@apollo.backplane.com>
References:  <200306152041.h5FKfoQo002747@apollo.backplane.com> <3EECF1EE.7000201@mac.com> <200306152351.h5FNptsC011948@apollo.backplane.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote:
[ ... ]
>     Looks good.  Wow, you came up with that pretty fast!  There was an
>     issue w/ your archive, the Makefile needs to use a tab instead of
>     spaces for that indented line.  But other then that it appears to work 
>     fine.

Ah, the post-install line?  Thanks.  Although I have to say, figuring out that 
the project Makefile didn't actually install the manpage took me longer than 
anything else.  [ :-) / 2 ]

>     There is also one niggling issue of the binaries being installed suid-root
>     which you might want to patch to 755 for security reasons, but it isn't
>     a show stopper.

Hmm.  If the project needn't be installed setuid-root, then maybe this should be 
pushed back to the author?  He should change the perms used by his install target.

-Chuck




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3EED4790.6060302>