Date: Mon, 29 Oct 2001 17:19:37 -0700 From: Warner Losh <imp@harmony.village.org> To: Luigi Rizzo <rizzo@aciri.org> Cc: "Andrew R. Reiter" <arr@watson.org>, Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <200110300019.f9U0Jb795315@harmony.village.org> In-Reply-To: Your message of "Sun, 28 Oct 2001 21:20:26 PST." <20011028212026.A94510@iguana.aciri.org> References: <20011028212026.A94510@iguana.aciri.org> <200110290441.f9T4fSY68423@freefall.freebsd.org> <Pine.NEB.3.96L.1011029000720.32447A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011028212026.A94510@iguana.aciri.org> Luigi Rizzo writes: : On Mon, Oct 29, 2001 at 12:11:24AM -0500, Andrew R. Reiter wrote: : > : > Sorry to reply to ipfw.c commits this way, but while there have been style : > fixes, I don't think all have been fixed. For example, in show_ipfw(), : > there is char timestr[30]; which is found in the middle of an if block. : > IIRC, isn't this a style problem as well? Also, I would imagine that it's : > just poor design to have to declare variables in the middle of a block, : > whether it be an if-block, for-block, etc.. : : actually it is _good_ design to declare variables as local as : possible, because it enables the compiler to detect more erroneous : use of the same. That's a matter of some debate. I'll just leave it at that. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110300019.f9U0Jb795315>