Date: Sat, 28 Mar 2015 10:36:13 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Eric van Gyzen <vangyzen@freebsd.org> Cc: current@freebsd.org, Rui Paulo <rpaulo@me.com> Subject: Re: SSE in libthr Message-ID: <20150328173613.GE51048@funkthat.com> In-Reply-To: <5515CF1C.8010409@FreeBSD.org> References: <5515AED9.8040408@FreeBSD.org> <3A96AAEC-9C1C-444E-9A73-3CD2AED33116@me.com> <5515CF1C.8010409@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Eric van Gyzen wrote this message on Fri, Mar 27, 2015 at 17:43 -0400:
> On 03/27/2015 16:49, Rui Paulo wrote:
> >
> > Regarding your patch, I think we should disable even more, if possible. How about:
> >
> > CFLAGS+= -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3
>
> Yes, I was considering copying all of the similar flags that we use in the
> kernel. That seems wise. According to comments in sys/conf/kern.mk, only
> no-mmx and no-sse would be necessary, as they imply the others.
>
> dim@ raised the possibility of CPUTYPE=foo on i386, so I would also apply this
> change to i386.
>
> An updated patch is below.
We should probably add a $(CFLAGS_NOFPU) define and use that.. Then it
can be properly tweaked per compiler and per arch as necessary instead
of hardcoding the selection in each makefile...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150328173613.GE51048>