Date: Sat, 14 Sep 2002 23:18:02 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Tim Zingelman <zingelman@fnal.gov> Cc: stable@freebsd.org, re@freebsd.org, anholt@freebsd.org Subject: RE: missing break in recent patch to agp_i810.c Message-ID: <XFMail.20020914231802.jhb@FreeBSD.org> In-Reply-To: <Pine.GSO.4.43.0209142034260.1655-100000@nova.fnal.gov>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15-Sep-2002 Tim Zingelman wrote: > My I810 system broke and gave this message... > > agp0: unknown memory configuration, disabling > device_probe_and_attach: agp0 attach returned 22 > > with the 1.1.2.4 revision of agp_i810.c. A little investigation shows > there is clearly a missing 'break;' in a switch statement. The following > patch fixes it. > > --- agp_i810.c.RELENG_4 Sat Sep 14 19:27:10 2002 > +++ agp_i810.c Sat Sep 14 20:56:16 2002 > @@ -219,6 +219,7 @@ > case 0x71258086: > case 0x11328086: > sc->chiptype = CHIP_I810; > + break; > case 0x35778086: > case 0x25628086: > sc->chiptype = CHIP_I830; > > Release engineering please consider commit approval for this fix. Certainly! Approved conditional on Eric's consent. Thanks for testing this and tracking this down. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020914231802.jhb>