Date: Tue, 15 Oct 2013 15:00:14 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Bryan Drewery <bryan@shatow.net> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com>, Allan Jude <freebsd@allanjude.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Devin Teske <dteske@FreeBSD.org> Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <20131015145032.GD98118@admin.xzibition.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <20131015145032.GD98118@admin.xzibition.com>
next in thread | previous in thread | raw e-mail | index | archive | help
CC'ing Allan Jude for feedback (I didn't have a hand in the selection of those values) --=20 Devin On Oct 15, 2013, at 7:50 AM, Bryan Drewery wrote: > On Fri, Oct 11, 2013 at 08:41:35PM +0000, Devin Teske wrote: >> Author: dteske >> Date: Fri Oct 11 20:41:35 2013 >> New Revision: 256343 >> URL: http://svnweb.freebsd.org/changeset/base/256343 >>=20 >> Log: >> Add zfsboot module as an option for automatic configuration. Default is >> to run interactively but it can be scripted too (optinally completely >> non-interactive). Currently supports GELI and all ZFS vdev types. Also >> performs validation on selections/settings providing error messages if >> necessary, explaining (in plain language) what the issue is. Currently >> the auto partitioning of naked disks only supports GPT and MBR (VTOC8 >> pending for sparc64), so is only available for i386/amd64 install. >>=20 >> Submitted by: Allan Jude <freebsd@allanjude.com>, myself >> Reviewed by: Allan Jude <freebsd@allanjude.com> >> Approved by: re (glebius) >>=20 >> Added: >> head/usr.sbin/bsdinstall/scripts/zfsboot (contents, props changed) >> Modified: >> head/usr.sbin/bsdinstall/bsdinstall >> head/usr.sbin/bsdinstall/scripts/Makefile >> head/usr.sbin/bsdinstall/scripts/auto >> head/usr.sbin/bsdinstall/scripts/config >>=20 >> +# Should we use gnop(8) to configure a transparent mapping to 4K sector= s? >> +# >> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=3D1} >=20 > I believe this trick is no longer needed after r254591. >=20 >> *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** > ... >> +# Default name for the boot environment parent dataset >> +# >> +: ${ZFSBOOT_BEROOT_NAME:=3Dbootenv} > ... >> + # Set bootfs property >> + zpool set bootfs=3D"$poolname/$ZFSBOOT_BEROOT_NAME/$ZFSBOOT_BOOT= FS_NAME" \ >> + "$poolname" || return $FAILURE >=20 > Can you please make ZFSBOOT_BEROOT_NAME be ROOT by default? This is what > sysutils/beadm, OpenSolaris/Illumos beadm, and I believe PC-BSD all expect > and use as well. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13CA24D6AB415D428143D44749F57D720FC6A04C>