Date: Fri, 1 Aug 2014 06:44:31 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Max Brazhnikov <makc@freebsd.org>, Antoine Brodin <antoine@FreeBSD.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, William Grzybowski <wg@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <20140801064431.GG71116@FreeBSD.org> In-Reply-To: <53DB3665.6020201@marino.st> References: <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ%2Bw@mail.gmail.com> <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st> <20140801062047.GC71116@FreeBSD.org> <53DB32E8.7020700@marino.st> <20140801063243.GE71116@FreeBSD.org> <53DB3665.6020201@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 01, 2014 at 08:40:37AM +0200, John Marino wrote:
> On 8/1/2014 08:32, Alexey Dokuchaev wrote:
> > Well, my original idea (bail out with an error) is how I saw we prevent
> > overwriting: by asserting that output file does not exist; you think it
> > is not robust enough?
>
> No, because you don't cover the case where both files legitimately need
> patching. Why bail out with error when I *want* both patches to exist?
> You are forcing me to rename one? to what
I see your point; I was thinking that if user will get this error, she will
choose a different character; but now I'll follow what you suggest.
> I've been using "_" => "__" for a while now, it's not bad. Yes, double
> underscore remains but a very low frequency. The main issue is that it
> represents a different character ("_") than it does now ("\").
OK, I agree.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140801064431.GG71116>