Date: Thu, 23 May 2002 03:46:01 -0700 (PDT) From: Shizuka Kudo <shizukakudo_99@yahoo.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Jay <jayed@jayed.com>, kris@obsecurity.org, sreese@codysbooks.com, freebsd-current@FreeBSD.ORG Subject: Re: Infinite 'make' loops while building ports Message-ID: <20020523104601.63164.qmail@web11405.mail.yahoo.com> In-Reply-To: <20020523101528.GA91566@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--- Marcel Moolenaar <marcel@xcllnt.net> wrote: > On Thu, May 23, 2002 at 02:33:56AM -0700, Shizuka > Kudo wrote: > > > > It seems /usr/bin/make set the environment > variable > > MAKEFILE to the Makefile it uses. So when you type > > make build or install, MAKEFILE is pointed to the > > port's Makefile. Workaround for me at this moment > is > > to run "make build MAKEFILE=Makefile" so that > > bsd.ports.mk use the correct Makefile in WRKSRC. > > > > Is the behaviour in /usr/bin/make changed > recently? > > No. This is old behaviour and I filed a PR for it > many moons ago. > I have replaced all uses of MAKEFILE with MAKE_FILE > in all the > makefiles that set it (and changed bsd.ports.mk as > well of course) > The problem is more visible if you set WRKDIROREFIX. > > -- > Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net You're right. The only reason it didn't show up several days before is that v 1.58 added the real path to MAKEFILE as mentioned in the commit log: Make ReadMakefile() operate using the realpath(3) name for the file handed to it, which means that relative paths will be expanded to absolute paths, and filenames without a path will end up with their absolute path included as well. This aids tremendously in debugging a build using our make(1) with multiple Makefile's, such as when there is a syntax error in a file in a sub-directory as per <bsd.subdir.mk>. Normally we'd end up with just "Makefile" known about the Makefile in question, which means that an error would be useless for someone trying to debug their build system, now we end up with a complete real pathname for the Makefile. So mostly this is useful in a debugging context, but possibly others too (I haven't thought of them yet, but they probably are more useful if you make Dir_FindFile use realpath(3), but that's another story). __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020523104601.63164.qmail>