Date: Sun, 26 Jan 2014 16:06:16 -0200 From: Renato Botelho <garga@FreeBSD.org> To: Andrej Zverev <az@freebsd.org>, Martin Wilke <miwi@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator Message-ID: <52E54E98.8080307@FreeBSD.org> In-Reply-To: <CAD5bB%2BgSAO4BFGpCTgC7HiOTxT6i2fwgmtbxupmHVgR5tWEQJQ@mail.gmail.com> References: <201401261514.s0QFEZY7093314@svn.freebsd.org> <CAD5bB%2BgSAO4BFGpCTgC7HiOTxT6i2fwgmtbxupmHVgR5tWEQJQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --edSB6XxlSmbN0FMiR5KpWiADPlL5sjGXF Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 26-01-2014 13:23, Andrej Zverev wrote: > On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke <miwi@freebsd.org> wrote:= >> Author: miwi >> Date: Sun Jan 26 15:14:34 2014 >> New Revision: 341219 >> URL: http://svnweb.freebsd.org/changeset/ports/341219 >> QAT: https://qat.redports.org/buildarchive/r341219/ >> >> Log: >> - Stage support >> >> >> Modified: head/www/xpi-unplug/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/www/xpi-unplug/Makefile Sun Jan 26 15:14:03 2014 = (r341218) >> +++ head/www/xpi-unplug/Makefile Sun Jan 26 15:14:34 2014 = (r341219) >> @@ -12,7 +12,6 @@ COMMENT=3D Converts embedded media to html >> XPI_ID=3D unplug@compunach >> XPI_NUM=3D 2254 >> >> -NO_STAGE=3D yes >> xpi-post-extract: >> ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf >> >> >> Modified: head/www/xpi-urllink/Makefile >=20 >=20 > Can you at least run portlint and fix easy warnings in such commits? li= ke > "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}" > when "${FIND} ... -delete" will work" find -delete won't delete a not empty directory. And this find is only looking for directories. --=20 Renato Botelho <garga @ FreeBSD.org> <garga.bsd @ gmail.com> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc --edSB6XxlSmbN0FMiR5KpWiADPlL5sjGXF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJS5U6YAAoJEPHw56GfYleQmQYQAIZRt77/RzvJymdaJSKLF/v1 5R6XzspZRPmE0WPgmfULDWfkPdVHZZPnMBukT3COVJ2gJCr/RlLO2noCh9IFal72 yQ5OndIHI9SJzvZ3LdawRQTjBmPnhxxmRI1JdGFVrRpYp4crHrBddlm8bALODb7X RT3nBpiFX8SvAyEm98qVD1zs8x61ykIliNGXXc1TLB6JeWuSGa541+q8UZb/cjzY 2OTcnfDqNrdsuqB3AF7Y5PvFpmreL9ri3aNKX1IwDZ9Su9E87XEzp0S3129xWnDq ljrvHliXeIjKWXsZ6IoNbMmodaFm/CYmuGzlqZ9BXXWbra/tOnZs5sEX9WWtSo3T 7ivXeZN5WgFJeaGxCKsjjk5ezSHl/zh974hKr1JB8IN4/y1d5T/U5DYWVKe1H30V xZqIdTKIMuStq5uhy9KzBNuWPh0XuNdOKyYzYlD+LKnT4Jvlw3okE9PKOm2jUYx+ 3B5sNd/B1g3mZYZKhvD3uUcZMQI7mFSaF7hFGWYasRVXxhIBlTyP6zGGxgH42XuW eQPXoiGwS0wUiHwgkJfx9zxgiZ29UAvtrTz4f+JYpXCxT6jGl5U0UWqk3uqIUdeE 3/Ue1sZo956uOyniEzxfyMWT28CPAcXV5t+f5QVE+gFoGyJu9oHsl6WnUH/p1IRa HpceIhbm7VT6zHYQtL4Z =pHoY -----END PGP SIGNATURE----- --edSB6XxlSmbN0FMiR5KpWiADPlL5sjGXF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52E54E98.8080307>