Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Sep 2010 07:08:37 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Rui Paulo <rpaulo@freebsd.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r213002 - in stable/8: include lib/libc/gen
Message-ID:  <20100923070247.L716@delplex.bde.org>
In-Reply-To: <201009221800.o8MI0Ze3038214@svn.freebsd.org>
References:  <201009221800.o8MI0Ze3038214@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Sep 2010, Rui Paulo wrote:

> Log:
>  MFC r197804 (rwatson):
>    Add basename_r(3) to complement basename(3).  basename_r(3) which accepts
>    a caller-allocated buffer of at least MAXPATHLEN, rather than using a
>    global buffer.

MAXPATHLEN has been deprecated for more than 20 years.  Please don't use
it in new interfaces.  A few man pages, not including basename.3, have
been updated to spell it PATH_MAX (should be {PATH_MAX}).

>  Note about semantics: while this interface is not POSIXy, there's
>  another major platform that uses it (Android) and the semantics between
>  the two platforms are pretty much the same.

It is also not non-POSIX...

> Modified: stable/8/include/libgen.h
> ==============================================================================
> --- stable/8/include/libgen.h	Wed Sep 22 16:54:22 2010	(r213001)
> +++ stable/8/include/libgen.h	Wed Sep 22 18:00:34 2010	(r213002)
> @@ -36,6 +36,7 @@
> __BEGIN_DECLS
>
> char	*basename(const char *);
> +char	*basename_r(const char *, char *);
> char	*dirname(const char *);
> #if 0
> char	*regcmp(const char *, ...);
>

...since it is declared in the POSIX namespace.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100923070247.L716>