Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Dec 2004 00:58:52 +0100
From:      "Simon L. Nielsen" <simon@FreeBSD.org>
To:        Mark Linimon <linimon@lonesome.com>
Cc:        freebsd-doc@FreeBSD.org
Subject:   Re: CFD: update to Porter's Handbook to document build Makevars
Message-ID:  <20041212235851.GM767@zaphod.nitro.dk>
In-Reply-To: <Pine.LNX.4.44.0412121644060.22127-100000@pancho>
References:  <Pine.LNX.4.44.0412121644060.22127-100000@pancho>

next in thread | previous in thread | raw e-mail | index | archive | help

--prC3/KjdfqNV7evK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2004.12.12 16:49:06 -0600, Mark Linimon wrote:

> I plan to commit it unless someone points out any markup bugs.

If few nits below, otherwise it looks good.

> Index: book.sgml
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/FreeBSD/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/b=
ook.sgml,v
> retrieving revision 1.500
> diff -u -r1.500 book.sgml
> --- book.sgml	12 Dec 2004 14:15:09 -0000	1.500
> +++ book.sgml	12 Dec 2004 21:26:58 -0000
> @@ -3484,6 +3484,12 @@
>  	  package itself, or else forcing its installation with
>  	  <makevar>FORCE_PKG_REGISTER</makevar> will no longer work.
>         </para>
> +
> +      <note>
> +	<para><makevar>CONFLICTS</makevar> automatically sets
> +	  <makevar>IGNORE</makevar>, which is more fully documented
> +	  <link linkend=3D"dads-noinstall">here.</link></para>

Links which says "here" is generally a bad idea, they will not really
make sense in a printed version..

I would suggest:

	  in <xref linkend=3D"dads-noinstall">.</para>

[...]
> +	    <para>If a port sould be marked <makevar>IGNORE</makevar>
> +	      only on certain architectures, there are two other
> +	      convenience variables that will automatically set
> +	      <makevar>IGNORE</makevar> for you:
> +	      <makevar>ONLY_FOR_ARCHS</makevar> and
> +	      <makevar>NOT_FOR_ARCHS</makevar>.  Examples:</para>
> +
> +	    <programlisting>ONLY_FOR_ARCHS =3D i386 amd64</programlisting>
> +
> +	    <programlisting>NOT_FOR_ARCHS =3D alpha ia64 sparc64</programlistin=
g>

Isn't there normally no space between the variable name and the equal
character in the ports Makefiles?

> @@ -8285,7 +8346,7 @@
>        <para>The &os; Ports Collection is constantly changing.  Here is
>  	some information on how to keep up.</para>
> =20
> -      <sect1>
> +      <sect1 id=3D"FreshPorts">

Was it intetionally that you used capital letters here?

>  	<title>FreshPorts</title>
> =20
>  	<para>One of the easiest ways to learn about updates that have
> @@ -8345,8 +8406,8 @@
> =20
>        </sect1>
> =20
> -      <sect1>
> -	<title>The &os; Port Building Cluster</title>
> +      <sect1 id=3D"build-cluster">
> +	<title>The &os; Port Building Cluster on pointyhat</title>

I would suggest:

	<title>The &os; Port Building Cluster on
	  <hostid role=3D"hostname">pointyhat</hostid></title>

--=20
Simon L. Nielsen

--prC3/KjdfqNV7evK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBvNs7h9pcDSc1mlERAqB6AKDFrkM5C0ngqM0GV0jGIG3sJC7f9wCeJ9Di
gzSBCdQ41t4FSenTABjwS8s=
=o9x0
-----END PGP SIGNATURE-----

--prC3/KjdfqNV7evK--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041212235851.GM767>