Date: Mon, 27 Dec 2004 22:24:54 -0800 From: "David O'Brien" <obrien@freebsd.org> To: "Andrew R. Reiter" <arr@watson.org> Cc: John Baldwin <jhb@freebsd.org> Subject: Re: cvs commit: src/sys/kern subr_witness.c Message-ID: <20041228062454.GA56882@dragon.nuxi.com> In-Reply-To: <20041227172424.A85914@fledge.watson.org> References: <200412262252.iBQMqPe7060613@repoman.freebsd.org> <20041227005456.GA57720@xor.obsecurity.org> <200412271600.26989.jhb@FreeBSD.org> <20041227172424.A85914@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 27, 2004 at 05:27:44PM -0500, Andrew R. Reiter wrote: > On Mon, 27 Dec 2004, John Baldwin wrote: > > :On Sunday 26 December 2004 07:54 pm, Kris Kennaway wrote: > :> On Sun, Dec 26, 2004 at 10:52:24PM +0000, Robert Watson wrote: > :> > rwatson 2004-12-26 22:52:24 UTC > :> > > :> > FreeBSD src repository > :> > > :> > Modified files: > :> > sys/kern subr_witness.c > :> > Log: > :> > Add "show alllocks" command to DDB, which dumps a list of processes > :> > and threads currently holding sleep mutexes (and spin mutexes for > :> > curthread). This can be quite useful in looking for a lock condition > :> > summary for a system, as it avoids manually iterating through threads > :> > and processes to find all the interesting locks. > :> > > :> > NB: "alllocks" is up there with "lockedvnods" for a bad argument for > :> > show. > :> > :> ITYM "allloks" or perhaps "alllockes" (conservation of vowels). > : > :If you want a better name you could do 'show locks /a' instead. That is, add > :support to 'show locks' for the /a option (see 'show ktr' for how you would > :handle this by looking at 'modif'). > : > > Seems like a good idea to me, John. My only -- very minor -- issue with > that is using '/' as the flag delimiter. Not trying to be an asshole or > anything, just seems to me that (unless there is some ddb options already > there that use '/') using the forward slash is very cmd.exe-esque. VAX VMS actually. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041228062454.GA56882>