Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Apr 2009 17:45:53 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Maksim Yevmenkin <emax@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   Re: svn commit: r190808 - stable/7/etc/rc.d
Message-ID:  <20090407174553.GA33627@FreeBSD.org>
In-Reply-To: <200904071629.n37GTowo014360@svn.freebsd.org>
References:  <200904071629.n37GTowo014360@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 07, 2009 at 04:29:50PM +0000, Maksim Yevmenkin wrote:
> Author: emax
> Date: Tue Apr  7 16:29:50 2009
> New Revision: 190808
> URL: http://svn.freebsd.org/changeset/base/190808
> 
>  ipfw_start()
>  {
> +	local   _firewall_type
> +
> +	_firewall_type=$1 

Why extra tab and not simply "local _firewall_type=$1"?

> -run_rc_command "$1"
> +run_rc_command $*

I haven't looked at the implementation of run_rc_command but "$1"
suggests it should be "$@" instead.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090407174553.GA33627>