Date: Tue, 30 Apr 2002 04:10:10 -0700 (PDT) From: Alexey Zelkin <phantom@FreeBSD.ORG> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x Message-ID: <200204301110.g3UBAAD91835@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/37566; it has been noted by GNATS. From: Alexey Zelkin <phantom@FreeBSD.ORG> To: David Gilbert <dgilbert@velocet.ca> Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x Date: Tue, 30 Apr 2002 14:04:09 +0300 hi, On Mon, Apr 29, 2002 at 05:30:20PM -0400, David Gilbert wrote: > Alexey> It's not possible to just merge this revision since adding > Alexey> this function require many locale specific merges as well. I > Alexey> think port itself should be fixed. BTW, how it compiles for > Alexey> 4.5 and more earlies releases which also not have > Alexey> nl_langinfo() ? > > Alexey> PS: Actually since it's not a security fix, I doubt that > Alexey> security officer will approve this addition :-( > > Well... you could also back out 1.13.2.1 ... > > Problem is: 1.13 works, 1.13.2.1 doesn't work (4.5-RELEASE), 1.13.2.2 > works. I not sure in exact problem you have, but looking for dates 1.13.2.2 (2001/11/02) was committed two months before 4.5-RELEASE. > it would appear that the null function is sufficient, but it was > removed. Without even the null function, gal fails to compile. : $ cvs log nl_langinfo.c [dd] : RELENG_4_5_0_RELEASE: 1.13.2.2 : RELENG_4_5: 1.13.2.2.0.2 : RELENG_4_5_BP: 1.13.2.2 : RELENG_4: 1.13.0.2 [dd] : revision 1.13.2.2 : date: 2001/11/07 04:50:32; author: ache; state: dead; lines: +1 -1 : Back out fake nl_langinfo() stub addition, it breaks configure for ports : programs badly. Better way is to merge its full variant and as result : full locale from -current. : ---------------------------- : revision 1.13.2.1 : date: 2001/11/02 19:42:07; author: obrien; state: Exp; lines: +5 -166 : Add a NOP nl_langinfo(). The purpose is to get an "nl_langinfo" symbol : into libc for some minor compatibility with 5-CURRENT binaries. Its : external exposure is kept down to a minium. : If one ln's libc.so.4 to libc.so.5 a surprising number of 5-CURRENT binaries : will run on RELENG_4. From this log you can see why NOP nl_langinfo() was added and why was backed out. Also you can see that nl_langinfo.c file should not be present at RELENG_4_5 branch. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204301110.g3UBAAD91835>