Date: Wed, 6 Jun 2001 16:44:00 +0100 (BST) From: Brian Somers <brian@Awfulhak.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/27909: bsd.ports.mk's fetch-list target is wrong [PATCH included] Message-ID: <200106061544.f56Fi0L59680@dev.lan.Awfulhak.org>
next in thread | raw e-mail | index | archive | help
>Number: 27909
>Category: ports
>Synopsis: bsd.ports.mk's fetch-list target is wrong [PATCH included]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 06 08:50:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Brian Somers
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
Awfulhak Ltd.
>Environment:
System: FreeBSD dev.lan.Awfulhak.org 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed Jun 6 10:01:37 BST 2001 brian@dev.lan.Awfulhak.org:/usr/obj/usr/src/sys/DEV i386
File: $FreeBSD: ports/Mk/bsd.port.mk,v 1.367 2001/05/23 02:46:52 dougb Exp $
>Description:
Doing a ``make fetch-list'' under /usr/ports produces a command
that only attempts to fetch from the first master site. This is
because of an (apparently) extraneous break in bsd.port.mk.
>How-To-Repeat:
cd /usr/ports/x11/XFree86-4
make DISTDIR=/tmp fetch-list
rmdir /tmp/xc
This only produces a command with a single fetch attempt.
>Fix:
Apply this:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.367
diff -u -r1.367 bsd.port.mk
--- bsd.port.mk 2001/05/23 02:46:52 1.367
+++ bsd.port.mk 2001/06/06 15:35:05
@@ -2317,8 +2317,7 @@
*/*) args="-o $${file} $${site}$${file}";; \
*) args=$${site}$${file};; \
esac; \
- ${ECHO} -n ${SETENV} ${FETCH_ENV} ${FETCH_CMD} ${FETCH_BEFORE_ARGS} $${args} "${FETCH_AFTER_ARGS}" '||' ; \
- break; \
+ ${ECHO} -n ${SETENV} ${FETCH_ENV} ${FETCH_CMD} ${FETCH_BEFORE_ARGS} $${args} "${FETCH_AFTER_ARGS}" '|| ' ; \
done; \
${ECHO} "echo $${file} not fetched" ; \
fi \
@@ -2334,8 +2333,7 @@
*/*) args="-o $${file} $${site}$${file}";; \
*) args=$${site}$${file};; \
esac; \
- ${ECHO} -n ${SETENV} ${FETCH_ENV} ${FETCH_CMD} ${FETCH_BEFORE_ARGS} $${args} "${FETCH_AFTER_ARGS}" '||' ; \
- break; \
+ ${ECHO} -n ${SETENV} ${FETCH_ENV} ${FETCH_CMD} ${FETCH_BEFORE_ARGS} $${args} "${FETCH_AFTER_ARGS}" '|| ' ; \
done; \
${ECHO} "echo $${file} not fetched" ; \
fi \
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106061544.f56Fi0L59680>