Date: Mon, 15 Jun 2009 12:38:27 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: Sam Leffler <sam@freebsd.org>, current@freebsd.org Subject: Re: [RFC]: (void)0 instead of empty defines Message-ID: <53E03A0A-8846-4EED-AE95-A15960FC6724@mac.com> In-Reply-To: <20090615185812.GA67104@freebsd.org> References: <20090615181555.GA52009@freebsd.org> <4A369529.5090004@freebsd.org> <20090615185812.GA67104@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 15, 2009, at 11:58 AM, Roman Divacky wrote: >> Are you saying that: >> >> if (cond) >> ; >> >> is considered worthy of a warning by the compiler? Is it just "if" >> or >> all conditional control constructs (e.g. while)? >> >> I can image many instances of this construct arising from debugging >> facilities. This sounds like a stupid restriction and I would >> argue we >> should just disable the warning. > > it already found a bug in csup (recently fixed by lulf). It sure can > be > disabled but I'd like it to be discussed a little bit more as it > already > proved to be useful. If the patch is all we need to compile the kernel with the warning enabled and knowing that the warning has already found real bugs, then it's a no-brainer to me: commit. -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53E03A0A-8846-4EED-AE95-A15960FC6724>