Date: Fri, 11 Jan 2008 00:54:39 -0500 From: James Cook <james.cook@utoronto.ca> To: Kris Kennaway <kris@freebsd.org> Cc: ports@freebsd.org, james.cook@utoronto.ca, Robert Huff <roberthuff@rcn.com> Subject: Re: freebsd-games: hack needs -fwritable-strings Message-ID: <20080111055439.GA1502@glider> In-Reply-To: <478697BF.5020604@FreeBSD.org> References: <20080110174126.GA45584@glider> <18310.35480.307764.676937@jerusalem.litteratus.org> <478697BF.5020604@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 10, 2008 at 11:10:07PM +0100, Kris Kennaway wrote: > Robert Huff wrote: > >James Cook writes: > > > >> This seems to be caused by line 170 of hack.u_init.c, which > >> attempts to modify a string constant. > >> > >> SOLUTION: > >> Add -fwritable-strings to CFLAGS in hack's Makefile. (There's > >> already a patch that changes that line of the Makefile, so this > >> is easy to change.) > > > > Has something changed in the definition of correctly written > >code while I was away at the funny farm? Why is the solution not > >"Don't modify a costant."? > > This code has been largely untouched since the 1980s :) > > Kris I like to think of the code as a museum artifact. An age-old scroll, written in an archaic language just close enough to modern C for us to understand. The original form will always be preserved somewhere, though. If somebody has the energy to modernize the code, I'm happy. James
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080111055439.GA1502>