Date: Tue, 26 Feb 2008 16:35:13 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Anton Berezin <tobez@tobez.org> Cc: ports@freebsd.org, perl@freebsd.org, lth@freebsd.org, Yen-Ming Lee <leeym@leeym.com> Subject: Re: Port dependencies on p5-Test-* Message-ID: <86mypnrary.fsf@ds4.des.no> In-Reply-To: <20080226144203.GC30778@heechee.tobez.org> (Anton Berezin's message of "Tue\, 26 Feb 2008 15\:42\:03 %2B0100") References: <86zltpzrxt.fsf@ds4.des.no> <759236930802242324o614598d1i1a8ca3cc8c12478c@mail.gmail.com> <86prulibf4.fsf@ds4.des.no> <759236930802250245j646f5be5k8382bedbfb2a7c1e@mail.gmail.com> <868x19i6ky.fsf@ds4.des.no> <759236930802251702h694c4f5bn2c7c87c7c47c7cc@mail.gmail.com> <20080226122512.GA30778@heechee.tobez.org> <86ve4bsx8l.fsf@ds4.des.no> <20080226140456.GB30778@heechee.tobez.org> <867igrst0g.fsf@ds4.des.no> <20080226144203.GC30778@heechee.tobez.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Anton Berezin <tobez@tobez.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Why? If perl isn't installed, build that first. > > If perl is installed, use 'perl -M$MODULE -e "1;"' to check whether the > > module exists, or if a certain version is required, 'perl -e "use $MODU= LE > > $VERSION;"' > > I think it is a bad idea, because > > - you need the "build that first" part (currently we create the complete > list of direct dependencies before actually building anything; too many > things to change with regard to our current procedure if we get rid of > this constraint); The rest of the ports tree checks every dependency right before building it; I don't see why Perl ports should be any different. > - we introduce modules into the equation when before we had only ports a= nd > packages to worry about; Why? I don't see what the difference is between "check if gcc34 exists, otherwise install lang/gcc34" and "check if Test::Unit exists, otherwise install devel/p5-Test-Unit". Or would you say that dependency tests on binaries "introduce binaries into the equation when before we had only ports and packages to worry about"? > - "use $MODULE" might have unanticipated side effects since a bunch of > preamble code is executed [this is not a security risk as such (a > malicious port can do worse things already), but as a general principl= e I > don't like that]; OK, most of these ports define their dependencies in Makefile.PL. Guess how ExtUtils::MakeMaker checks for dependencies... DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86mypnrary.fsf>