Date: Fri, 11 Jan 2013 20:20:01 GMT From: Sean Bruno <seanbru@yahoo-inc.com> To: freebsd-scsi@FreeBSD.org Subject: Re: kern/151564: [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 107 Message-ID: <201301112020.r0BKK1gt063403@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/151564; it has been noted by GNATS. From: Sean Bruno <seanbru@yahoo-inc.com> To: bug-followup@FreeBSD.org, leon.kos@lecad.fs.uni-lj.si Cc: Subject: Re: kern/151564: [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 107 Date: Fri, 11 Jan 2013 12:15:41 -0800 --=-ORZ+S4oOqTjltqlLU7pH Content-Type: multipart/mixed; boundary="=-qMd4ViJxxLLO8lizsr4e" --=-qMd4ViJxxLLO8lizsr4e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable After speaking with HP a bit about the MAX_LOGICAL/PHYSICAL things, they've suggested that we simply ask the controller what the device can support as per http://cciss.sourceforge.net/#docs revision 1.06 I came up with this patch that does that and I'm looking for more review. Tested on a P400, P410 and P420 that I have. =20 If this is acceptable, please break the exposing of physical disks into a seperate patch so I can review. Sean verbose output ciss0: <HP Smart Array P400> port 0xe800-0xe8ff mem 0xfce00000-0xfcefffff,0xfcdff000-0xfcdfffff irq 16 at device 0.0 on pci6 ciss0: PERFORMANT Transport ciss0: attempting to allocate 1 MSI-X vectors (4 supported) msi: routing MSI-X IRQ 256 to local APIC 0 vector 52 ciss0: using IRQ 256 for MSI-X ciss0: Using 1 MSIX interrupt ciss0: using 1024 of 1024 available commands ciss0: 2 logical drives configured ciss0: firmware 5.26 ciss0: 1 SCSI channels ciss0: signature 'CISS' ciss0: valence 3 ciss0: supported I/O methods 0xe0000006<simple,performant> ciss0: active I/O method 0x5<performant> ciss0: 4G page base 0x00000000 ciss0: interrupt coalesce delay 0us ciss0: interrupt coalesce count 16 ciss0: max outstanding commands 1024 ciss0: bus types 0x200000 ciss0: server name '' ciss0: heartbeat 0xe57 ciss0: max logical: 64 ciss0: max physical: 255 ciss0: max logical: 128 ciss0: 13 physical devices ciss0: 2 logical drives ciss0: logical drive (b0t0): RAID 1(1+0), 285696MB online ciss0: logical drive (b0t1): RAID 0, 1399808MB online --=-qMd4ViJxxLLO8lizsr4e Content-Disposition: attachment; filename="ciss_probe_logical_physical.diff" Content-Type: text/x-patch; name="ciss_probe_logical_physical.diff"; charset="UTF-8" Content-Transfer-Encoding: base64 SW5kZXg6IGNpc3MuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGNpc3MuYwkocmV2aXNpb24gMjQ1MzEwKQ0K KysrIGNpc3MuYwkod29ya2luZyBjb3B5KQ0KQEAgLTEyMDUsMTEgKzEyMDUsOSBAQA0KIA0KICAg ICAvKiBwcmludCBpbmZvcm1hdGlvbiAqLw0KICAgICBpZiAoYm9vdHZlcmJvc2UpIHsNCi0jaWYg MAkvKiBYWFggcHJveHkgdm9sdW1lcz8/PyAqLw0KIAljaXNzX3ByaW50ZihzYywgIiAgJWQgbG9n aWNhbCBkcml2ZSVzIGNvbmZpZ3VyZWRcbiIsDQogCQkgICAgc2MtPmNpc3NfaWQtPmNvbmZpZ3Vy ZWRfbG9naWNhbF9kcml2ZXMsDQogCQkgICAgKHNjLT5jaXNzX2lkLT5jb25maWd1cmVkX2xvZ2lj YWxfZHJpdmVzID09IDEpID8gIiIgOiAicyIpOw0KLSNlbmRpZg0KIAljaXNzX3ByaW50ZihzYywg IiAgZmlybXdhcmUgJTQuNHNcbiIsIHNjLT5jaXNzX2lkLT5ydW5uaW5nX2Zpcm13YXJlX3Jldmlz aW9uKTsNCiAJY2lzc19wcmludGYoc2MsICIgICVkIFNDU0kgY2hhbm5lbHNcbiIsIHNjLT5jaXNz X2lkLT5zY3NpX2J1c19jb3VudCk7DQogDQpAQCAtMTIzMiw2ICsxMjMwLDE2IEBADQogCQkgICAg IlwyMFwxdWx0cmEyXDJ1bHRyYTNcMTBmaWJyZTFcMTFmaWJyZTJcbiIpOw0KIAljaXNzX3ByaW50 ZihzYywgIiAgc2VydmVyIG5hbWUgJyUuMTZzJ1xuIiwgc2MtPmNpc3NfY2ZnLT5zZXJ2ZXJfbmFt ZSk7DQogCWNpc3NfcHJpbnRmKHNjLCAiICBoZWFydGJlYXQgMHgleFxuIiwgc2MtPmNpc3NfY2Zn LT5oZWFydGJlYXQpOw0KKwlpZiAoc2MtPmNpc3NfY2ZnLT5tYXhfbG9naWNhbF9zdXBwb3J0ZWQg PT0gMCkgDQorCQlzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCA9IENJU1NfTUFY X0xPR0lDQUw7DQorICAgIAljaXNzX3ByaW50ZihzYywgIiAgbWF4IGxvZ2ljYWwgbG9naWNhbCB2 b2x1bWVzOiAlZFxuIiwNCisJCQlzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCk7 DQorCWlmIChzYy0+Y2lzc19jZmctPm1heF9waHlzaWNhbF9zdXBwb3J0ZWQgPT0gMCkgDQorCQlz Yy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCA9IENJU1NfTUFYX1BIWVNJQ0FMOw0K KyAgICAJY2lzc19wcmludGYoc2MsICIgIG1heCBwaHlzaWNhbCBkaXNrcyBzdXBwb3J0ZWQ6ICVk XG4iLA0KKwkJCXNjLT5jaXNzX2NmZy0+bWF4X3BoeXNpY2FsX3N1cHBvcnRlZCk7DQorICAgIAlj aXNzX3ByaW50ZihzYywgIiAgbWF4IHBoeXNpY2FsIGRpc2tzIHBlciBsb2dpY2FsIHZvbHVtZTog JWRcbiIsDQorCQkJc2MtPmNpc3NfY2ZnLT5tYXhfcGh5c2ljYWxfcGVyX2xvZ2ljYWwpOw0KICAg ICB9DQogDQogb3V0Og0KQEAgLTEzMTksNyArMTMyNyw3IEBADQogCWJyZWFrOw0KICAgICBjYXNl IENJU1NfQ01EX1NUQVRVU19EQVRBX09WRVJSVU46DQogCWNpc3NfcHJpbnRmKHNjLCAiV0FSTklO RzogbW9yZSB1bml0cyB0aGFuIGRyaXZlciBsaW1pdCAoJWQpXG4iLA0KLQkJICAgIENJU1NfTUFY X0xPR0lDQUwpOw0KKwkJICAgIHNjLT5jaXNzX2NmZy0+bWF4X2xvZ2ljYWxfc3VwcG9ydGVkKTsN CiAJYnJlYWs7DQogICAgIGRlZmF1bHQ6DQogCWNpc3NfcHJpbnRmKHNjLCAiZXJyb3IgZGV0ZWN0 aW5nIGxvZ2ljYWwgZHJpdmUgY29uZmlndXJhdGlvbiAoJXMpXG4iLA0KQEAgLTEzNTMsNyArMTM2 MSw3IEBADQogICAgIGRlYnVnX2NhbGxlZCgxKTsNCiANCiAgICAgY2xsID0gY2lzc19yZXBvcnRf bHVucyhzYywgQ0lTU19PUENPREVfUkVQT1JUX0xPR0lDQUxfTFVOUywNCi0JCQkgICBDSVNTX01B WF9MT0dJQ0FMKTsNCisJCQkgICBzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCk7 DQogICAgIGlmIChjbGwgPT0gTlVMTCkgew0KIAllcnJvciA9IEVOWElPOw0KIAlnb3RvIG91dDsN CkBAIC0xMzYxLDkgKzEzNjksMTAgQEANCiANCiAgICAgLyogc2FuaXR5LWNoZWNrIHJlcGx5ICov DQogICAgIG5kcml2ZXMgPSAobnRvaGwoY2xsLT5saXN0X3NpemUpIC8gc2l6ZW9mKHVuaW9uIGNp c3NfZGV2aWNlX2FkZHJlc3MpKTsNCi0gICAgaWYgKChuZHJpdmVzIDwgMCkgfHwgKG5kcml2ZXMg PiBDSVNTX01BWF9MT0dJQ0FMKSkgew0KLQljaXNzX3ByaW50ZihzYywgImFkYXB0ZXIgY2xhaW1z IHRvIHJlcG9ydCBhYnN1cmQgbnVtYmVyIG9mIGxvZ2ljYWwgZHJpdmVzICglZCA+ICVkKVxuIiwN Ci0JCSAgICBuZHJpdmVzLCBDSVNTX01BWF9MT0dJQ0FMKTsNCisgICAgaWYgKChuZHJpdmVzIDwg MCkgfHwgKG5kcml2ZXMgPiBzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCkpIHsN CisJY2lzc19wcmludGYoc2MsICJhZGFwdGVyIGNsYWltcyB0byByZXBvcnQgYWJzdXJkIG51bWJl ciINCisJCQkib2YgbG9naWNhbCBkcml2ZXMgKCVkID4gJWQpXG4iLA0KKwkgICAgCQluZHJpdmVz LCBzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZCk7DQogCWVycm9yID0gRU5YSU87 DQogCWdvdG8gb3V0Ow0KICAgICB9DQpAQCAtMTM4NiwxOSArMTM5NSwyMCBAQA0KIA0KICAgICBm b3IgKGkgPSAwOyBpIDw9IHNjLT5jaXNzX21heF9sb2dpY2FsX2J1czsgaSsrKSB7DQogCXNjLT5j aXNzX2xvZ2ljYWxbaV0gPQ0KLQkgICAgbWFsbG9jKENJU1NfTUFYX0xPR0lDQUwgKiBzaXplb2Yo c3RydWN0IGNpc3NfbGRyaXZlKSwNCisJICAgIG1hbGxvYyhzYy0+Y2lzc19jZmctPm1heF9sb2dp Y2FsX3N1cHBvcnRlZCAqDQorCQkgICBzaXplb2Yoc3RydWN0IGNpc3NfbGRyaXZlKSwNCiAJCSAg IENJU1NfTUFMTE9DX0NMQVNTLCBNX05PV0FJVCB8IE1fWkVSTyk7DQogCWlmIChzYy0+Y2lzc19s b2dpY2FsW2ldID09IE5VTEwpIHsNCiAJICAgIGVycm9yID0gRU5YSU87DQogCSAgICBnb3RvIG91 dDsNCiAJfQ0KIA0KLQlmb3IgKGogPSAwOyBqIDwgQ0lTU19NQVhfTE9HSUNBTDsgaisrKQ0KKwlm b3IgKGogPSAwOyBqIDwgc2MtPmNpc3NfY2ZnLT5tYXhfbG9naWNhbF9zdXBwb3J0ZWQ7IGorKykN CiAJICAgIHNjLT5jaXNzX2xvZ2ljYWxbaV1bal0uY2xfc3RhdHVzID0gQ0lTU19MRF9OT05FWElT VEVOVDsNCiAgICAgfQ0KIA0KIA0KLSAgICBmb3IgKGkgPSAwOyBpIDwgQ0lTU19NQVhfTE9HSUNB TDsgaSsrKSB7DQorICAgIGZvciAoaSA9IDA7IGkgPCBzYy0+Y2lzc19jZmctPm1heF9sb2dpY2Fs X3N1cHBvcnRlZDsgaSsrKSB7DQogCWlmIChpIDwgbmRyaXZlcykgew0KIAkgICAgc3RydWN0IGNp c3NfbGRyaXZlCSpsZDsNCiAJICAgIGludAkJCWJ1cywgdGFyZ2V0Ow0KQEAgLTE0NDAsNyArMTQ1 MCw3IEBADQogICAgIHRhcmdldCA9IDA7DQogDQogICAgIGNsbCA9IGNpc3NfcmVwb3J0X2x1bnMo c2MsIENJU1NfT1BDT0RFX1JFUE9SVF9QSFlTSUNBTF9MVU5TLA0KLQkJCSAgIENJU1NfTUFYX1BI WVNJQ0FMKTsNCisJCQkgICBzYy0+Y2lzc19jZmctPm1heF9waHlzaWNhbF9zdXBwb3J0ZWQpOw0K ICAgICBpZiAoY2xsID09IE5VTEwpIHsNCiAJZXJyb3IgPSBFTlhJTzsNCiAJZ290byBvdXQ7DQpA QCAtMTk4Myw3ICsxOTkzLDcgQEANCiAJYnVzX2RtYV90YWdfZGVzdHJveShzYy0+Y2lzc19wYXJl bnRfZG1hdCk7DQogICAgIGlmIChzYy0+Y2lzc19sb2dpY2FsKSB7DQogCWZvciAoaSA9IDA7IGkg PD0gc2MtPmNpc3NfbWF4X2xvZ2ljYWxfYnVzOyBpKyspIHsNCi0JICAgIGZvciAoaiA9IDA7IGog PCBDSVNTX01BWF9MT0dJQ0FMOyBqKyspIHsNCisJICAgIGZvciAoaiA9IDA7IGogPCBzYy0+Y2lz c19jZmctPm1heF9sb2dpY2FsX3N1cHBvcnRlZDsgaisrKSB7DQogCQlpZiAoc2MtPmNpc3NfbG9n aWNhbFtpXVtqXS5jbF9sZHJpdmUpDQogCQkgICAgZnJlZShzYy0+Y2lzc19sb2dpY2FsW2ldW2pd LmNsX2xkcml2ZSwgQ0lTU19NQUxMT0NfQ0xBU1MpOw0KIAkJaWYgKHNjLT5jaXNzX2xvZ2ljYWxb aV1bal0uY2xfbHN0YXR1cykNCkBAIC0yOTY2LDkgKzI5NzYsOSBAQA0KIAljcGktPmhiYV9pbnF1 aXJ5ID0gUElfVEFHX0FCTEU7CS8qIFhYWCBpcyB0aGlzIGNvcnJlY3Q/ICovDQogCWNwaS0+dGFy Z2V0X3NwcnQgPSAwOw0KIAljcGktPmhiYV9taXNjID0gMDsNCi0JY3BpLT5tYXhfdGFyZ2V0ID0g Q0lTU19NQVhfTE9HSUNBTDsNCisJY3BpLT5tYXhfdGFyZ2V0ID0gc2MtPmNpc3NfY2ZnLT5tYXhf bG9naWNhbF9zdXBwb3J0ZWQ7DQogCWNwaS0+bWF4X2x1biA9IDA7CQkvKiAnbG9naWNhbCBkcml2 ZScgY2hhbm5lbCBvbmx5ICovDQotCWNwaS0+aW5pdGlhdG9yX2lkID0gQ0lTU19NQVhfTE9HSUNB TDsNCisJY3BpLT5pbml0aWF0b3JfaWQgPSBzYy0+Y2lzc19jZmctPm1heF9sb2dpY2FsX3N1cHBv cnRlZDsNCiAJc3RybmNweShjcGktPnNpbV92aWQsICJGcmVlQlNEIiwgU0lNX0lETEVOKTsNCiAg ICAgICAgIHN0cm5jcHkoY3BpLT5oYmFfdmlkLCAibXNtaXRoQGZyZWVic2Qub3JnIiwgSEJBX0lE TEVOKTsNCiAgICAgICAgIHN0cm5jcHkoY3BpLT5kZXZfbmFtZSwgY2FtX3NpbV9uYW1lKHNpbSks IERFVl9JRExFTik7DQpAQCAtMzg3OSw3ICszODg5LDcgQEANCiAgICAgICogZHJpdmUgYWRkcmVz cy4NCiAgICAgICovDQogICAgIGNsbCA9IGNpc3NfcmVwb3J0X2x1bnMoc2MsIENJU1NfT1BDT0RF X1JFUE9SVF9MT0dJQ0FMX0xVTlMsDQotICAgICAgICAgICAgICAgICAgICAgICAgICAgQ0lTU19N QVhfTE9HSUNBTCk7DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgc2MtPmNpc3NfY2ZnLT5t YXhfbG9naWNhbF9zdXBwb3J0ZWQpOw0KICAgICBpZiAoY2xsID09IE5VTEwpDQogICAgICAgICBy ZXR1cm47DQogDQpAQCAtMzg5MCw3ICszOTAwLDcgQEANCiAgICAgICogZmlybXdhcmUuDQogICAg ICAqLw0KICAgICBmb3IgKGkgPSAwOyBpIDwgc2MtPmNpc3NfbWF4X2xvZ2ljYWxfYnVzOyBpKysp IHsNCi0JZm9yIChqID0gMDsgaiA8IENJU1NfTUFYX0xPR0lDQUw7IGorKykgew0KKwlmb3IgKGog PSAwOyBqIDwgc2MtPmNpc3NfY2ZnLT5tYXhfbG9naWNhbF9zdXBwb3J0ZWQ7IGorKykgew0KIAkg ICAgbGQgPSAmc2MtPmNpc3NfbG9naWNhbFtpXVtqXTsNCiANCiAJICAgIGlmIChsZC0+Y2xfdXBk YXRlID09IDApDQpAQCAtNDA1OSw3ICs0MDY5LDcgQEANCiAJICAgICAqIFJlc2NhbiB0aGUgcGh5 c2ljYWwgbHVuIGxpc3QgZm9yIG5ldyBpdGVtcw0KIAkgICAgICovDQogCSAgICBjbGwgPSBjaXNz X3JlcG9ydF9sdW5zKHNjLCBDSVNTX09QQ09ERV9SRVBPUlRfUEhZU0lDQUxfTFVOUywNCi0JCQkJ ICAgQ0lTU19NQVhfUEhZU0lDQUwpOw0KKwkJCQkgICBzYy0+Y2lzc19jZmctPm1heF9waHlzaWNh bF9zdXBwb3J0ZWQpOw0KIAkgICAgaWYgKGNsbCA9PSBOVUxMKSB7DQogCQljaXNzX3ByaW50Zihz YywgIldhcm5pbmcsIGNhbm5vdCBnZXQgcGh5c2ljYWwgbHVuIGxpc3RcbiIpOw0KIAkJYnJlYWs7 DQpAQCAtNDMwNyw3ICs0MzE3LDcgQEANCiAJIlwyMFwxbm90aWZ5X29rXDJjb250cm9sX29wZW5c M2Fib3J0aW5nXDRydW5uaW5nXDIxZmFrZV9zeW5jaFwyMmJtaWNfYWJvcnRcbiIpOw0KIA0KICAg ICBmb3IgKGkgPSAwOyBpIDwgc2MtPmNpc3NfbWF4X2xvZ2ljYWxfYnVzOyBpKyspIHsNCi0JZm9y IChqID0gMDsgaiA8IENJU1NfTUFYX0xPR0lDQUw7IGorKykgew0KKwlmb3IgKGogPSAwOyBqIDwg c2MtPmNpc3NfY2ZnLT5tYXhfbG9naWNhbF9zdXBwb3J0ZWQ7IGorKykgew0KIAkgICAgY2lzc19w cmludGYoc2MsICJMT0dJQ0FMIERSSVZFICVkOiAgIiwgaSk7DQogCSAgICBjaXNzX3ByaW50X2xk cml2ZShzYywgJnNjLT5jaXNzX2xvZ2ljYWxbaV1bal0pOw0KIAl9DQpJbmRleDogY2lzc3JlZy5o DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQotLS0gY2lzc3JlZy5oCShyZXZpc2lvbiAyNDUzMTApDQorKysgY2lzc3Jl Zy5oCSh3b3JraW5nIGNvcHkpDQpAQCAtNDI1LDYgKzQyNSwxNSBAQA0KICNkZWZpbmUgQ0lTU19E UklWRVJfREFVR0hURVJfQVRUQUNIRUQJCSgxPDw4KQ0KICNkZWZpbmUgQ0lTU19EUklWRVJfU0NT SV9QUkVGRVRDSAkJKDE8PDkpDQogICAgIHVfaW50MzJfdAltYXhfc2dfbGVuZ3RoOwkJLyogMzEg aW4gb2xkZXIgZmlybXdhcmUgKi8NCisvKg0KKyAqIHRoZXNlIGZpZWxkcyBhcHBlYXIgaW4gT3Bl bkNJU1MgU3BlYyAxLjA2DQorICogaHR0cDovL2NjaXNzLnNvdXJjZWZvcmdlLm5ldC8jZG9jcw0K KyAqLw0KKyAgICB1X2ludDMyX3QJbWF4X2xvZ2ljYWxfc3VwcG9ydGVkOw0KKyAgICB1X2ludDMy X3QJbWF4X3BoeXNpY2FsX3N1cHBvcnRlZDsNCisgICAgdV9pbnQzMl90CW1heF9waHlzaWNhbF9w ZXJfbG9naWNhbDsNCisgICAgdV9pbnQzMl90CW1heF9wZXJmb21hbnRfbW9kZV9jbWRzOw0KKyAg ICB1X2ludDMyX3QJbWF4X2Jsb2NrX2ZldGNoX2NvdW50Ow0KIH0gX19wYWNrZWQ7DQogDQogLyoN Cg== --=-qMd4ViJxxLLO8lizsr4e-- --=-ORZ+S4oOqTjltqlLU7pH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAABAgAGBQJQ8HLtAAoJEBkJRdwI6BaHnXYH/3W224hbAArOSCC3b7iOw6QK BLaGTzbO6aMDYr3tUVmJumAa6xv85cwcRiaf/viDbb9LSeeJaf3esCalPeGMhJUa ioNRx0QbdAFOPoVhqVhu+70BhAw3sqHe+2/rAHBDAqfgwKdTUyJQIH9ah+LmWWnO lykGgEC7Yw1Wk6aDY7QBneA5jT6E1SL069JqY5c2q9x0nxHoCWXNO1e7ErAzvbEj 45P5d9bs3wlpdVa3CqDiTa+A8lA9QxuQ1TpPF0xgojxOXuOzaIJC7co+sbY5+uFt 8ZnRkW/fjCBY1LJPrVu3QRuXmGipqUAba5YZW7wI2tZE2NNKCxKNFjUUU4B6UqI= =EgP7 -----END PGP SIGNATURE----- --=-ORZ+S4oOqTjltqlLU7pH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301112020.r0BKK1gt063403>